Iceberg integration plugin impl#22407
Draft
sachin-27 wants to merge 13 commits into
Draft
Conversation
…iceberg catalog Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
Contributor
PR Code Analyzer ❗AI-powered 'Code-Diff-Analyzer' found issues on commit 50731d4. 'Diff too large, requires skip by maintainers after manual review' Pull Requests Author(s): Please update your Pull Request according to the report above. Repository Maintainer(s): You can Thanks. |
- Add @experimentalapi to PublishShardAction/Request/Response so the API annotation processor accepts them (was blocking :server:compileJava). - Bind MetadataClient (real when configured, null provider otherwise) and RemoteSegmentStoreDirectoryFactory in Node's Guice module. TransportPublishShardAction is registered unconditionally and eagerly instantiated; without these bindings, node startup fails on any node that does not configure a catalog. - Update CatalogRepository.snapshotShard override to match the new 11-arg Repository abstract method on main (added @nullable IndexMetadata). - Fix jackson-annotations version reference to versions.jackson_annotations (split from versions.jackson on main). - Remove IcebergMetadataClientPublishTests and ParquetFileUploaderTests; RemoteSegmentStoreDirectory is now final on main and Mockito can no longer mock it. Tests will be restored in a follow-up rewrite. Signed-off-by: Sachin Sriramagiri <srirasac@amazon.com>
sachin-27
force-pushed
the
iceberg-integration-plugin-impl
branch
from
27b7829 to
50731d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.