Remove warnings not applicable to omp server #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NexiusTailer
requested review from
a team,
NermanLegacy,
daddyDOT and
itsneufox
as code owners
itsneufox
approved these changes
Jan 4, 2026
Collaborator
|
waiting on @AmyrAhmady input |
AmyrAhmady
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some of the warnings which was applicable to SA-MP server natives, but now it's not a thing in open.mp server, namely:
playeridis equal toforplayeridin open.mp server, so it returns true in this case, while SA-MP server returns false (thus the warning is not suitable for omp anymore). But as for this, I'd like to also hear some opinion from @Southclaws or @AmyrAhmady if it should be changed in docs or in omp, so the warning could be left as it's now and a potential behavior difference changed in the server itself...