Repository navigation
Update cpp-httplib to v0.66.0 and harden the artwork web server - #1296
Merged
Merged
Conversation
ksenonadv
commented
Nov 14, 2026
Member
- Bump lib/cpp-httplib to upstream v0.66.0 (openmultiplayer fork, ksn/update), which also rejects path traversal attempts on mounted directories.
- Replace the removed httplib::detail::encode_url with httplib::encode_uri.
- Only bind the artwork web server to IPv4 and reject any non-IPv4 peer, so the IP allowlist can no longer be bypassed over IPv6 or IPv4-mapped addresses.
- Match the .dff/.txd extension at the end of the path, case-insensitively.
- Capture the HTTP thread count by value instead of a dangling reference.
- Bind synchronously, wait until the server is ready instead of sleeping, and join the listener thread on shutdown instead of detaching it.
- Lock the allowlist mutex before looking up entries.
- Bump lib/cpp-httplib to upstream v0.66.0 (openmultiplayer fork, ksn/update), which also rejects path traversal attempts on mounted directories. - Replace the removed httplib::detail::encode_url with httplib::encode_uri. - Only bind the artwork web server to IPv4 and reject any non-IPv4 peer, so the IP allowlist can no longer be bypassed over IPv6 or IPv4-mapped addresses. - Match the .dff/.txd extension at the end of the path, case-insensitively. - Capture the HTTP thread count by value instead of a dangling reference. - Bind synchronously, wait until the server is ready instead of sleeping, and join the listener thread on shutdown instead of detaching it. - Lock the allowlist mutex before looking up entries. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cpp-httplib v0.66 loads root certificates from the macOS Keychain by default when OpenSSL support is enabled, which needs these frameworks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AmyrAhmady
marked this pull request as ready for review
November 16, 2026 12:14
AmyrAhmady
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.