Skip to content

Update cpp-httplib to v0.66.0 and harden the artwork web server - #1296

Merged
AmyrAhmady merged 2 commits into
masterfrom
ksn/update-httplib
Nov 16, 2026
Merged

AmyrAhmady merged 2 commits into
masterfrom
ksn/update-httplib

Conversation

@ksenonadv

Copy link
Copy Markdown
Member
  • Bump lib/cpp-httplib to upstream v0.66.0 (openmultiplayer fork, ksn/update), which also rejects path traversal attempts on mounted directories.
  • Replace the removed httplib::detail::encode_url with httplib::encode_uri.
  • Only bind the artwork web server to IPv4 and reject any non-IPv4 peer, so the IP allowlist can no longer be bypassed over IPv6 or IPv4-mapped addresses.
  • Match the .dff/.txd extension at the end of the path, case-insensitively.
  • Capture the HTTP thread count by value instead of a dangling reference.
  • Bind synchronously, wait until the server is ready instead of sleeping, and join the listener thread on shutdown instead of detaching it.
  • Lock the allowlist mutex before looking up entries.

- Bump lib/cpp-httplib to upstream v0.66.0 (openmultiplayer fork, ksn/update),
  which also rejects path traversal attempts on mounted directories.
- Replace the removed httplib::detail::encode_url with httplib::encode_uri.
- Only bind the artwork web server to IPv4 and reject any non-IPv4 peer,
  so the IP allowlist can no longer be bypassed over IPv6 or IPv4-mapped
  addresses.
- Match the .dff/.txd extension at the end of the path, case-insensitively.
- Capture the HTTP thread count by value instead of a dangling reference.
- Bind synchronously, wait until the server is ready instead of sleeping,
  and join the listener thread on shutdown instead of detaching it.
- Lock the allowlist mutex before looking up entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ksenonadv
ksenonadv requested a review from AmyrAhmady November 14, 2026 12:12
cpp-httplib v0.66 loads root certificates from the macOS Keychain by
default when OpenSSL support is enabled, which needs these frameworks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AmyrAhmady
AmyrAhmady marked this pull request as ready for review November 16, 2026 12:14
@AmyrAhmady
AmyrAhmady merged commit 2b4a69d into master Nov 16, 2026
15 checks passed
@AmyrAhmady
AmyrAhmady deleted the ksn/update-httplib branch November 16, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants