Enhance keyboard accessibility for clean table modal - #5399
Open
ajrbyers wants to merge 3 commits into
Open
Conversation
…uthor details list
ajrbyers
force-pushed
the
b-5387-keyboard-nav-regressions
branch
from
July 21, 2026 11:34
85098cf to
7a185ff
Compare
StephDriver
reviewed
Jul 24, 2026
Member
There was a problem hiding this comment.
Confirmed & approved:
-
clean keyboard trap where having opened a modal it could not be dismissed has been resolved.
-
olh page links now keep focus at landing point rather than sending it to top of page.
Questions
- Did the scope of this include the Figure modals? there's something not quite right, as if having tabbed to the close button, one tabs again, it is possible to end up back on the main page, but with it still in shadow because the modal hasn't closed. I think when open the modal should keep focus trapped to the modal until it is dismissed, certainly it shouldn't return to the main page without dismissing the modal.
The table modals keep the focus within the modal until dismissed, the figure modals do not.
- Is there a related clarity PR? The bug affected clean and clarity.
StephDriver
requested changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5387