8372534: Update Libpng to 1.6.51

[gnu-andrew]

Update to the latest version of libpng. Changes from Awt2dLibraries.gmk were dropped as warnings are not split by file in 17u (missing JDK-8294466) and there are still unused warnings from splashscreen_impl.c in both 17u & 21u. The change built fine with GCC 8 on RHEL 8.

I'm proposing this during rampdown so the release ships with the latest version, as we also do with e.g. tzdata.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• JDK-8372534 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8372534: Update Libpng to 1.6.51 (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewers without OpenJDK IDs

• @khanbilal732 (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u.git pull/415/head:pull/415
$ git checkout pull/415

Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.org/jdk17u.git pull/415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 415

View PR using the GUI difftool:
$ git pr show -t 415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u/pull/415.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372534: Update Libpng to 1.6.51

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• b03c019: 8317970: Bump target macosx-x64 version to 11.00.00

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (0c54be9e)

[MBaesken]

Maybe you could get rid of the unused-function warning disabling for gcc in 17 too (see Awt2dLibraries.gmk ) , but up to you!

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[MBaesken]

Update to the latest version of libpng. Changes from Awt2dLibraries.gmk were dropped as warnings are not split by file in 17u (missing JDK-8294466) and there are still unused warnings from splashscreen_impl.c in both 17u & 21u. The change built fine with GCC 8 on RHEL 8.

Okay I see, you cannot remove the warning disabling.

[gnu-andrew]

Update to the latest version of libpng. Changes from Awt2dLibraries.gmk were dropped as warnings are not split by file in 17u (missing JDK-8294466) and there are still unused warnings from splashscreen_impl.c in both 17u & 21u. The change built fine with GCC 8 on RHEL 8.

Okay I see, you cannot remove the warning disabling.

No, not as it stands (I did try). We could backport JDK-8294466 - I was actually surprised to find that the underlying support for it is already there but only used by HotSpot - but that's something for 17u-dev after this.

[gnu-andrew]

Thanks for the reviews.
/approval request Regular update for the in-tree copy of libpng. The backport from 21 is nearly clean - just the warning changes in the Makefile have to be dropped for now - and GHA builds & testing have passed. The patch was reviewed by Matthias Bäsken

[openjdk]

@gnu-andrew
8372534: The approval request has been created successfully.

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit 86a5a83.
Since your change was applied there has been 1 commit pushed to the master branch:

• b03c019: 8317970: Bump target macosx-x64 version to 11.00.00

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit 86a5a83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.