Skip to content

images: --push prints the digest the registry serves (podman: --digestfile) - #69

Merged
manmohanbrahma merged 1 commit into
mainfrom
fix/build-push-digest
Nov 16, 2026
Merged

manmohanbrahma merged 1 commit into
mainfrom
fix/build-push-digest

Conversation

@manmohanbrahma

Copy link
Copy Markdown
Collaborator

images/*/build.sh --push printed the digest from image inspect RepoDigests. With podman that is the local manifest's digest: podman recompresses the layers on push and writes a new manifest, so the printed pin is one the registry does not have (S-5: manifest unknown, pin corrected by hand in #68). Docker's RepoDigests is the registry's.

  • images/lib.sh push_image: podman pushes with --digestfile and prints that digest; docker keeps RepoDigests. Used by images/sglang-rocm/build.sh and images/dynamo-vllm-rocm/build.sh.
  • tests/unit/test_push_digest.sh (fake podman and docker): failed on the old logic (got 'sha256:local'), passes now; also a failed push returns non-zero with its error in the log.
  • TASKS: S-5 note updated.

Lab check: the next podman --push (T-212) prints the digest GHCR reports for the tag.

…tfile)

podman recompresses layers on push and writes a new manifest, but its
RepoDigests keeps the local one: the S-5 pin from it got manifest unknown.
images/lib.sh push_image: podman push --digestfile; docker keeps RepoDigests
(which is the registry's). Used by sglang-rocm and dynamo-vllm-rocm build.sh.
tests/unit/test_push_digest.sh (fake podman and docker) failed on the old
logic (sha256:local) and passes now.
@manmohanbrahma
manmohanbrahma merged commit 586fbba into main Nov 16, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant