Repository navigation
images: --push prints the digest the registry serves (podman: --digestfile) - #69
Merged
Merged
Conversation
…tfile) podman recompresses layers on push and writes a new manifest, but its RepoDigests keeps the local one: the S-5 pin from it got manifest unknown. images/lib.sh push_image: podman push --digestfile; docker keeps RepoDigests (which is the registry's). Used by sglang-rocm and dynamo-vllm-rocm build.sh. tests/unit/test_push_digest.sh (fake podman and docker) failed on the old logic (sha256:local) and passes now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
images/*/build.sh --pushprinted the digest fromimage inspectRepoDigests. With podman that is the local manifest's digest: podman recompresses the layers on push and writes a new manifest, so the printed pin is one the registry does not have (S-5:manifest unknown, pin corrected by hand in #68). Docker's RepoDigests is the registry's.images/lib.shpush_image: podman pushes with--digestfileand prints that digest; docker keeps RepoDigests. Used byimages/sglang-rocm/build.shandimages/dynamo-vllm-rocm/build.sh.tests/unit/test_push_digest.sh(fake podman and docker): failed on the old logic (got 'sha256:local'), passes now; also a failed push returns non-zero with its error in the log.Lab check: the next podman
--push(T-212) prints the digest GHCR reports for the tag.