Repository navigation
oif bench: one run per node (B-1a) - #67
Merged
Merged
Conversation
In B-1 a second oif bench started while the first was between points and removed its server (6 points lost). A node-wide lock now refuses a second run and names the PID of the one running (ADR-009: one GPU under load at a time; one fixed server port). Containers do not inherit the lock. New tests/unit/test_bench_lock.sh (fails without the lock).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In B-1 a second
oif benchstarted while the first was between points and removed its server: 6 points lost./run/lock/oif-bench.lock,BENCH_LOCKfor tests) refuses a second run: another oif bench is running on this node (PID N). Per node, not per GPU: ADR-009 is one GPU under load at a time, and every run's server listens on port 8000.ctcloses fd 8), so it frees itself when the run ends.oifb-srvstays: with the lock no second run can remove it, and a crashed run's server is cleaned up by the next run.tests/unit/test_bench_lock.sh(fails without the lock; checked on Linux).[~]until the lab check (a second run on gpu-amd is refused).