fix: leftover CLI atoi - #1
Open
tonycoder-hub wants to merge 1 commit into
Open
tonycoder-hub wants to merge 1 commit into
tonycoder-hub wants to merge 1 commit into
Conversation
Parse retry_count, panic_count, and upgraded_pkg_num from untrusted updater CLI/misc with std::from_chars instead of atoi so overflow, empty, and partial tokens are rejected instead of aborting. Signed-off-by: Tony Coder <407243179@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InitOptionsFuncTabparses untrusted updater CLI / misc tokens--retry_count,--panic_count, and--upgraded_pkg_numwithatoi. Overflow is undefined behavior and can abort; empty/garbage becomes 0 (retry treated as first boot;pkgLocationwraps when a negativeatoiresult is cast tounsigned int).Parse via
std::from_chars(ParseCliNumber). Valid integers keep the same result; reject overflow/partial/empty and log withLOG(ERROR).Test plan
/workspace/test_parse_cli_number— valid0/1/8/INT_MAX/INT_MIN/UINT_MAXparse; overflow, empty, mixed, non-digits, and unsigned-negative rejected with no sanitizer reports.Signed-off-by: Tony Coder 407243179@qq.com