Skip to content

Conversation

@salman2013
Copy link
Contributor

@salman2013 salman2013 commented Jan 12, 2026

Description:

This PR lifts and shifts the Discussion XBlock from edx-platform.

The following file types were moved to ensure it loads correctly.

  • XBlock python code (All code in discussion_block has moved in xblock-contrib. For permission and provider setting we have created separate PR. For bundling of JS files we have created separate PR)
  • Converted Django templates (PR has already reviewed and merged in edx-platfrom)
  • JS files (all JS files moved into xblocks-contrib with no any logical change)
  • Css files (PR has already reviewed and merge in edx-platfrom)

Acceptance criteria:

  • Discussion block should properly load on cms and lms.
  • Check the UI on cms and lms, everything is loading properly.
  • Test cases should be green

Ticket:
openedx/public-engineering#451

Parent Ticket:
openedx/openedx-platform#36539

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 12, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 12, 2026

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@salman2013 salman2013 changed the title Salman/extract discussion block Discussion xblock extraction from edx-platform Jan 12, 2026
@salman2013 salman2013 force-pushed the salman/extract-discussion-block branch from facc73b to 18b36ec Compare January 12, 2026 15:17
@salman2013 salman2013 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Jan 12, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jan 16, 2026
@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 10, 2026
@salman2013 salman2013 requested a review from a team February 11, 2026 07:12
@salman2013 salman2013 marked this pull request as ready for review February 11, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

2 participants