feat: add AccountActivationEmailComposed and AccountActivationCompleted filters - #382
Draft
marlonkeating wants to merge 1 commit into
Draft
feat: add AccountActivationEmailComposed and AccountActivationCompleted filters#382marlonkeating wants to merge 1 commit into
marlonkeating wants to merge 1 commit into
Conversation
Merged
marlonkeating
force-pushed
the
mkeating/ENT-11816
branch
from
August 6, 2026 14:27
af5b313 to
840a36a
Compare
There was a problem hiding this comment.
Pull request overview
Adds two new public filters in the learning subdomain to support account activation customization, alongside a version bump and changelog entry.
Changes:
- Introduces
AccountActivationEmailComposedandAccountActivationCompletedpublic filters for activation email context and post-activation redirect customization. - Adds unit tests validating
filter_typevalues and default “no pipeline configured” behavior. - Bumps package version to 3.9.0 and documents the release in
CHANGELOG.rst.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| openedx_filters/learning/filters.py | Adds the two new account activation filters and their run_filter implementations. |
| openedx_filters/learning/tests/test_filters.py | Adds test coverage for the new filters’ type identifiers and default behavior. |
| openedx_filters/init.py | Updates the package __version__ to 3.9.0. |
| CHANGELOG.rst | Adds a 3.9.0 changelog entry documenting the new filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| filter_type = "org.openedx.learning.account.activation.email.compose.v1" | ||
|
|
||
| @classmethod | ||
| def run_filter(cls, user: Any, message_context: dict) -> tuple[Any, dict | None]: |
| @@ -35,6 +35,14 @@ Unreleased | |||
|
|
|||
| .. _changelog-3.7.0: | |||
Comment on lines
+1692
to
+1695
| tuple[User, str]: | ||
| - User: Django User object. | ||
| - str: URL to redirect to, possibly modified. Falsy values fall back to the | ||
| dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENT-11816
This pull request introduces two new public filters for account activation events and updates the package version to 3.9.0. It also includes comprehensive tests for the new filters and documents the changes in the changelog.
New Account Activation Filters:
AccountActivationEmailComposedfilter to allow modification of the activation email context before it is sent. (openedx_filters/learning/filters.py,openedx_filters/learning/tests/test_filters.py) [1] [2] [3]AccountActivationCompletedfilter to allow modification of the redirect URL after account activation. (openedx_filters/learning/filters.py,openedx_filters/learning/tests/test_filters.py) [1] [2] [3]Testing:
openedx_filters/learning/tests/test_filters.py)