build: add support for additional translation sources - #126
Merged
arbrandes merged 2 commits intoAug 12, 2026
Conversation
arbrandes
changed the title
arbrandes
requested changes
Aug 11, 2026
arbrandes
left a comment
arbrandes
left a comment
Contributor
There was a problem hiding this comment.
Can you please change the commit prefix from feat: to build:? I don't think this warrants a new minor version of the plugin.
If, on the other hand, you think this warrants a new NPM release, then a fix: would be ok.
alenkadev
force-pushed
the
alenka/switching-to-local-translations
branch
from
August 12, 2026 05:52
155d8b2 to
199f737
Compare
arbrandes
requested changes
Aug 12, 2026
arbrandes
left a comment
arbrandes
left a comment
Contributor
There was a problem hiding this comment.
It seems you missed a spot.
Co-authored-by: Adolfo R. Brandes <arbrandes@arbrand.es>
arbrandes
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Switch to using local translations (AU-2765)
Description:
Declares ATLAS_EXTRA_SOURCES, ATLAS_EXTRA_INTL_IMPORTS, and ATLAS_OPTIONS as overridable Makefile variables (?=, default empty).
Appends $(ATLAS_EXTRA_SOURCES) to the atlas pull command in pull_translations, so extra translations/: entries can be pulled alongside the existing ones.
Appends (ATLAS_EXTRA_INTL_IMPORTS) to the $(intl_imports) call, so any extra sources pulled above are also registered/imported
jira-link : https://2u-internal.atlassian.net/browse/LP-330