chore: pin pip for good. - #564
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a semi-permanent pip upper-bound to common_constraints.txt to prevent pip upgrades from breaking pip-tools consumers, with detailed rationale and explicit removal criteria.
Changes:
- Introduces a documented, semi-permanent
pip<26.2constraint incommon_constraints.txt. - Adds guidance on when/how to bump or remove the constraint (e.g., after
pip-toolsreleases, or after migrating away frompip-tools).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Seems reasonable while we do the migration. Since the issue that prompted this is fixed in pip-tools 7.6.1, can you just bump the pin to the latest |
pwnage101
force-pushed
the
pwnage101/pin-pip-for-good
branch
from
August 13, 2026 16:56
439d779 to
2f0684e
Compare
bmtcril
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets stop beating around the bush. edx-lint has added and removed this exact pin four times:
Until we finally migrate off pip-tools entirely, realistically we need to keep a permanent pip constraint in common_constraints.txt.