Skip to content

chore: pin pip for good. - #564

Merged
bmtcril merged 1 commit into
openedx:masterfrom
pwnage101:pwnage101/pin-pip-for-good
Aug 13, 2026
Merged

chore: pin pip for good.#564
bmtcril merged 1 commit into
openedx:masterfrom
pwnage101:pwnage101/pin-pip-for-good

Conversation

@pwnage101

@pwnage101 pwnage101 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Lets stop beating around the bush. edx-lint has added and removed this exact pin four times:

  • 2026-02-11 8578cb5 chore: Unpin pip < 26.0
  • 2026-02-03 e930f47 fix: pin pip < 26.0
  • 2025-12-05 dcb92c5 fix: remove pip-tools common_constraint
  • 2025-10-29 4410a03 fix: pin pip<25.3 to resolve make upgrade build failure
  • 2025-10-01 136df76 fix: Drop the constraint on pip
  • 2024-10-28 bf7ca95 chore: add common constraint for pip (pip<24.3)
  • 2022-05-16 fdddf3b fix: remove pip common constraint

Until we finally migrate off pip-tools entirely, realistically we need to keep a permanent pip constraint in common_constraints.txt.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a semi-permanent pip upper-bound to common_constraints.txt to prevent pip upgrades from breaking pip-tools consumers, with detailed rationale and explicit removal criteria.

Changes:

  • Introduces a documented, semi-permanent pip<26.2 constraint in common_constraints.txt.
  • Adds guidance on when/how to bump or remove the constraint (e.g., after pip-tools releases, or after migrating away from pip-tools).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread edx_lint/files/common_constraints.txt Outdated
@pwnage101
pwnage101 requested a review from bmtcril August 11, 2026 22:57
@bmtcril

bmtcril commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Seems reasonable while we do the migration. Since the issue that prompted this is fixed in pip-tools 7.6.1, can you just bump the pin to the latest 26.2.1?

@pwnage101
pwnage101 force-pushed the pwnage101/pin-pip-for-good branch from 439d779 to 2f0684e Compare August 13, 2026 16:56
@bmtcril
bmtcril merged commit c34fa8d into openedx:master Aug 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants