Merged
Conversation
JammingBen
added
Type:Maintenance
JammingBen
changed the title
This allows us to get rid of the `portal` usage. Apps can now directly use the `MobileNav` component. I needed to move a few more helpers from the runtime to web-pkg so they can be used globally.
JammingBen
force-pushed
the
refactor/mobile-nav-to-pkg
branch
from
1f11ef3 to
db19b8e
Compare
JammingBen
commented
Feb 19, 2026
Comment on lines
-24
to
-33
| it('initially sets the highlighter to the active nav item', async () => { | ||
| const { wrapper } = getWrapper() | ||
| await wrapper.vm.$nextTick() | ||
| expect(wrapper.vm.highlighterAttrs).toEqual({ | ||
| style: { | ||
| transform: 'translateY(0px)', | ||
| 'transition-duration': '0.2s' | ||
| } | ||
| }) | ||
| }) |
Member
Author
There was a problem hiding this comment.
The highlighter will be removed anyways with the redesign, no need to spend time on fixing this test now.
JammingBen
force-pushed
the
refactor/mobile-nav-to-pkg
branch
from
db19b8e to
3133b87
Compare
AlexAndBear
approved these changes
Feb 19, 2026
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Apps must now directly use the
MobileNavcomponent fromweb-pkginstead of using a portal.I needed to move a few some helpers from the runtime to web-pkg so they can be used globally.
refs #1936