Skip to content

feat: create or upload floating action button#1997

Open
AlexAndBear wants to merge 9 commits intomainfrom
issues/1960-drop-menu
Open

feat: create or upload floating action button#1997
AlexAndBear wants to merge 9 commits intomainfrom
issues/1960-drop-menu

Conversation

@AlexAndBear
Copy link
Member

@AlexAndBear AlexAndBear commented Feb 18, 2026

Description

Related Issue

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear changed the title feat: expunge create or upload drop into a component feat: create or upload floating action button Feb 18, 2026
@AlexAndBear AlexAndBear force-pushed the issues/1960-drop-menu branch from 7b38adb to b5f675d Compare February 18, 2026 21:14
Copy link
Member

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, already feels really good IMO! A few quirks I noticed, some may be for a follow-up.

  • The batch actions when selecting a file have a bit of margin to the left, that looks weird.
  • Didn't we say we want the action for creating spaces to be in this menu on the spaces overview page? I can't remember though 🤔
  • In views without a FAB we should make sure to align the first nav item with the headline/breadcrumb of the content area (or at least align the top and the left margin within the sidebar):
Image
  • When navigating into folders, the button blinks for a short time because it's disabled initially. While not dramatically bad, it's a bit annoying. But I doubt we can fix that easily. Maybe with some hacky debounce.

At last, but that's something for PM to decide, we could think about not disabling the button and just defaulting to creating in the personal space IMO. That's how other clouds do it. The disabling feels a bit weird to me... on the other hand though it's really transparent to the user we they are creating files, which wouldn't be the case if we implicitly default to the personal space.

@AlexAndBear
Copy link
Member Author

Nice, already feels really good IMO! A few quirks I noticed, some may be for a follow-up.

  • The batch actions when selecting a file have a bit of margin to the left, that looks weird.
  • Didn't we say we want the action for creating spaces to be in this menu on the spaces overview page? I can't remember though 🤔
  • In views without a FAB we should make sure to align the first nav item with the headline/breadcrumb of the content area (or at least align the top and the left margin within the sidebar):
Image * When navigating into folders, the button blinks for a short time because it's disabled initially. While not dramatically bad, it's a bit annoying. But I doubt we can fix that easily. Maybe with some hacky debounce.

At last, but that's something for PM to decide, we could think about not disabling the button and just defaulting to creating in the personal space IMO. That's how other clouds do it. The disabling feels a bit weird to me... on the other hand though it's really transparent to the user we they are creating files, which wouldn't be the case if we implicitly default to the personal space.

  • The batch actions when selecting a file have a bit of margin to the left, that looks weird. ✅
  • In views without a FAB we should make sure to align the first nav item with the headline/breadcrumb of the content area (or at least align the top and the left margin within the sidebar) ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make "Create or Upload" the FAB of the files app

2 participants

Comments