feat: create or upload floating action button#1997
Open
AlexAndBear wants to merge 9 commits intomainfrom
Open
Conversation
7b38adb to
b5f675d
Compare
JammingBen
reviewed
Feb 19, 2026
Member
JammingBen
left a comment
There was a problem hiding this comment.
Nice, already feels really good IMO! A few quirks I noticed, some may be for a follow-up.
- The batch actions when selecting a file have a bit of margin to the left, that looks weird.
- Didn't we say we want the action for creating spaces to be in this menu on the spaces overview page? I can't remember though 🤔
- In views without a FAB we should make sure to align the first nav item with the headline/breadcrumb of the content area (or at least align the top and the left margin within the sidebar):
- When navigating into folders, the button blinks for a short time because it's disabled initially. While not dramatically bad, it's a bit annoying. But I doubt we can fix that easily. Maybe with some hacky debounce.
At last, but that's something for PM to decide, we could think about not disabling the button and just defaulting to creating in the personal space IMO. That's how other clouds do it. The disabling feels a bit weird to me... on the other hand though it's really transparent to the user we they are creating files, which wouldn't be the case if we implicitly default to the personal space.
packages/web-app-files/tests/unit/components/CreateOrUploadMenu.spec.ts
Outdated
Show resolved
Hide resolved
packages/web-app-files/tests/unit/components/CreateOrUploadMenu.spec.ts
Outdated
Show resolved
Hide resolved
…u.spec.ts Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
…u.spec.ts Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Related Issue
How Has This Been Tested?
Types of changes