feat: adapt apply scan window#406
Merged
Merged
Conversation
Expand skip-heavy zero-close scans without changing close or worker limits, preserve close-health telemetry across comment sync, and extract apply helpers so GitHub can validate the workflow. Co-authored-by: brokemac79 <martin_cleary@yahoo.co.uk>
Move reusable apply helpers out of the inline run expression and add a regression ceiling below GitHub's 21,000-character validation limit.
Contributor
Author
|
Landed as a52b852. Final proof: exact head fb2d036; 134 focused tests; 600 unit + 599 repair tests; changed/full coverage gates; build, lint, format, ShellCheck, and actionlint clean; AutoReview clean at 0.84 confidence; all required GitHub checks green ( Thanks @brokemac79 for the adaptive scan baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #401 after GitHub rejected maintainer pushes to its forked head because the current OAuth token lacks
workflowscope. The published tree exactly matches the reviewed rewrite.This keeps the original proposal's useful policy: untargeted close-apply scans start at 300 records and can grow to 600, then a capped 900, only after a full skip-heavy window closes nothing. Close limits, checkpoints, worker counts, live checks, and policy gates do not change. Comment-sync status now preserves the last close-health sample so the next close run has the right input.
The rewrite also extracts reusable shell helpers from the oversized apply step. Current
mainexceeds GitHub's 21,000-character workflow-expression limit and produces zero-job failures; this head is below a tested 20,000-character ceiling.Proof:
bash -n, ShellCheck, actionlint, build, lint, format: clean17d15b0bdf023eb8c1d41a700ea00faff7c06dbc(exact reviewed tree)Co-authored-by: brokemac79 martin_cleary@yahoo.co.uk