Separate human-only PR intake signals#339
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 19, 2026, 9:22 AM ET / 13:22 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a PR adding a new intake classification path. Source review and the contributor's dry-run output cover both intended routing paths. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this only if maintainers accept the narrow human-only signal contract, while preserving author-wide intake and keeping failed checks, dirty merge states, and review blockers as repair jobs. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a PR adding a new intake classification path. Source review and the contributor's dry-run output cover both intended routing paths. Is this the best way to solve the issue? Yes, conditionally: the implementation is narrow and tested, but final acceptance is a maintainer policy call because it intentionally changes automation routing. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 471bf8065dd4. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Real dry-run proof addedI rebuilt and ran this branch locally from Validation: Result: 1. Metadata-only PR becomes
|
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Maintainer deep review found two blocking routing defects.
The supplied dry-runs use Required shape before reconsideration:
Relevant code: |
|
Closing after maintainer deep review. Current Detailed findings: #339 (comment) Thanks for exploring the intake boundary. |
Summary
Reintroduce only the focused human-only PR intake classification from #333, rebuilt on current
mainafter #335 landed.This PR classifies metadata-only ClawSweeper signals as
requires_humaninstead of enqueueing a repair job, while preserving repair jobs when objective repair blockers exist.Scope
Validation
Result:
Covered cases:
Real dry-run proof
After rebuilding this branch locally from
fix/human-only-pr-intake-v2, I reran the dry-runs requested by review.Validation:
Result:
1. Metadata-only PR becomes
requires_human, no repair jobCommand:
Redacted output summary:
{ "status": "ok", "repo": "openclaw/clawsweeper", "author": "Jhacarreiro", "scanned": 1, "candidates": 0, "requires_human": [ { "number": 339, "url": "https://github.com/openclaw/clawsweeper/pull/339", "reason": "No repairable blocker was detected. Remaining signals look like human/review workflow or stale metadata, so do not create an automatic repair job.", "repairable_signals": [], "metadata_signals": [ { "kind": "clawsweeper_rating", "detail": "label=rating: unranked krab" }, { "kind": "clawsweeper_status", "detail": "label=status: needs proof" }, { "kind": "clawsweeper_merge_risk", "detail": "label=merge-risk: automation" } ] } ], "jobs": [] }2. Objectively repairable PR still creates a repair job
Command:
Redacted output summary:
{ "status": "ok", "repo": "Jhacarreiro/clawsweeper", "author": "Jhacarreiro", "scanned": 1, "candidates": 1, "requires_human": [], "jobs": [ { "status": "planned", "job": "jobs/Jhacarreiro/inbox/repair-pr-jhacarreiro-clawsweeper-2.md", "number": 2, "signals": [ { "kind": "check_failed", "detail": "pnpm check: conclusion=FAILURE" } ] } ] }This covers both sides requested by review: metadata-only PRs are not enqueued as repair jobs, and objectively failed-check PRs remain repair candidates.