fix(proof): decouple supplied label from nudges#319
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 18, 2026, 4:26 PM ET / 20:26 UTC. Summary Reproducibility: yes. for the current behavior being changed: source inspection shows current main skips nudges on Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused cleanup only after maintainers confirm that ClawSweeper's reviewed report plus Do we have a high-confidence way to reproduce the issue? Yes for the current behavior being changed: source inspection shows current main skips nudges on Is this the best way to solve the issue? Yes, conditionally: the patch is the narrowest implementation if maintainers want the reviewed ClawSweeper report to own proof-nudge eligibility. If label removal should remain a manual pause, the safer path is to keep the live-label prerequisite and only retire AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a6ee02e323c1. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
74ee66b to
825de0f
Compare
|
Landed after maintainer policy approval and verification. Proof:
Landed commit: |
What Problem This Solves
OpenClaw's PR body gate is being narrowed to author-supplied problem context and validation evidence. ClawSweeper still owns the stronger real-behavior-proof decision, but its proof-nudge and dashboard code treated the old
proof: suppliedlabel as a proof state.Why This Change Was Made
Retire
proof: suppliedfrom ClawSweeper's proof-nudge and dashboard policy. Proof nudges now depend on ClawSweeper's reviewed report and skip onlyproof: sufficientorproof: override, while replacement PR label copying also filters OpenClaw's newtriage: needs-pr-contexthygiene label.User Impact
Maintainers keep one clear proof signal:
proof: sufficientmeans ClawSweeper judged the exact-head proof acceptable. Contributor PR body context can improve review readability without suppressing proof nudges or changing ClawSweeper's sufficiency gate.Evidence
pnpm run check