Changing output-background color code in partial-theming-watermark WF to a string#7752
Open
snoesberger wants to merge 1 commit into
Open
Changing output-background color code in partial-theming-watermark WF to a string#7752snoesberger wants to merge 1 commit into
output-background color code in partial-theming-watermark WF to a string#7752snoesberger wants to merge 1 commit into
Conversation
In the composite step of the partial-theming-watermark WF, the color code has to be defined as a string. Setting the value to a hex value like 0x000000FF leads to ffmpeg errors such as these: ``` (EncoderEngine:495) - [Parsed_pad_1 @ 0x55744f9d0c80] Invalid 0xRRGGBB[AA] color string: '255' (EncoderEngine:495) - [Parsed_pad_1 @ 0x55744f9d0c80] Unable to parse option value "255" as color ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the composite step of the partial-theming-watermark WF, the color code has to be defined as a string. Setting the value to a hex value like 0x000000FF leads to ffmpeg errors such as these:
This pull request targets the legacy branch because watermark theming has probably not been working since the introduction of the YAML-WF.
How to test this patch
Your pull request should…