Add a simple error boundary to the app#1638
Open
Arnei wants to merge 2 commits into
Open
Conversation
Instead of letting rendering errors cause a blank page, this employs react error boundaries to show a minimalistic error page instead. Does not catch other errors, i.e. during event handling.
Modals are self contained, so if there is an error in one it does not have to bring the whole application down with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1164.
Instead of letting rendering errors cause a blank page, this employs react error boundaries to show a minimalistic error page instead.
Also adds error boundaries to modals. Modals are self contained, so if there is an error in one it does not have to bring the whole application down with it.
Does not catch other errors, i.e. during event handling.