JWT Support [Release 10]#28
Conversation
- Access Permission check. - use streamVideo method from OpenCast plugin. - Provide refresh token method
github-project-automation
Bot
moved this to Backlog
in Opencast & Opencast PageComponent
| $message = $th->getMessage(); | ||
| if ( | ||
| $message && | ||
| str_contains($message, '401') || |
There was a problem hiding this comment.
Here we must have ( ) around the two str_contains, otherwise it won't work as expected. And: Isn't there another possibility to check this? searching the message for 401 or 403 seems to be a bit fragile IMOPV.
| exit; | ||
| $this->opencast_player_gui->streamVideo(); | ||
| } catch (\Throwable $th) { | ||
| $message = $th->getMessage(); |
There was a problem hiding this comment.
We will output the whole content of the exception, right? Can we have a more general message maybe?
|
|
||
| $this->paellaConfigServiceFactory = $opencast_dic->legacy()->paella_config_service_factory(); | ||
| $this->paellaConfigService = $this->paellaConfigServiceFactory->get(); | ||
| $this->opencast_player_gui = new xoctPlayerGUI( |
There was a problem hiding this comment.
I know there is currently no other way than that, we must introduce a "Player" using the \srag\Plugins\Opencast\UI\Integration\Integration in the near future to decouple this. creating a new instance of xoctPlayerGUI couples the plugins more, but as I said, maybe theres no better solution for the moment.
|
@ferishili I made some comments, at least the if () issue should be fixed before merging. same for #27 |
3 participants
JWT support for Release 10.
Refer to #27 for more info.