Add unit tests, see #24

[rbarillot]

Add unit tests in test/test_wheatfspm.py

[baugetfa]

Run fast on my machine.
Do not forget to change in conda.yaml in the test part the command to something like:

  commands:
    - cd test
    - pytest -v
    
``̀`

[rbarillot]

TY @baugetfa .
I modified the meta.yaml file according to your suggestion. Should I also modify the pyproject.toml in the test section, which is not consistant with the meta.yaml at present.
I have also noticed that the dependancies sections of the environment.yaml and pyproject.toml are not consistant either.

[baugetfa]

Yes. So because the CI is ok that means that the dependencies in meta.yaml are the good one so you can report them to the pyproject.toml. After that if you want you can change the requires: in meta.yaml as flollows:

test:
  requires:
    {% for dep in test_deps %}
    - {{ dep }}
    {% endfor %}

Then indeed the environment.yaml and pyproject.toml should be consistent so you just have to add openalea.widgets to environment.yaml. In the environment.yaml we list python, pip and conda dependencies after this is pip that will manage other dependencies.

[rbarillot]

It's a bit confusing for me, but I've made a new commit. Is it better that way? I'm not sure about the [project.optional-dependencies] test = section in the pyproject.toml

[rbarillot]

oups...it seems I broke the CI :/

[baugetfa]

That is normal because I forgot to tell you to add the following line at the beginning of the meta.yaml:

{% set test_deps = pyproject.get('project', {}).get('optional-dependencies', {}).get('test',[]) %}

This line defines test_deps. So just add this line just after the line starting by {% set conda_deps.

[rbarillot]

Great, CI was successful !
Can you confirm that the meta.yaml, pyproject.toml and environment.yml are consistent please?

[baugetfa]

Yes I confirm everything is consistent. I think you can merge if you finished with this PR.

[baugetfa]

Wait just

[baugetfa]

May be add to meta.yaml imports openalea.wheatfspm as follows:

test:
  requires:
    {% for dep in test_deps %}
    - {{ dep }}
    {% endfor %}

  imports:
    - openalea.wheatfspm

It is not mandatory, the proof is that the CI worked, but it is recommended.

[rbarillot]

the import statement seems to trigger an error.

[baugetfa]

Oups sorry I wrote openalea.wheatfspm but according to the test it is openalea.fspmwheat . This is a bit inconsistent with the project name. But what ever. So change to openalea.fspmwheat or just removed this import addition. Sorry again.

[rbarillot]

no problem! I just don't understand where it is specified openalea.fspmwheat rather than openalea.wheatfspm?

[baugetfa]

In your test_wheatfspm.py in your imports this is from openalea.fspmwheat import that is used. In src/openalea there is no wheatfspm only fspmwheat so openalea.wheatfspmdoes not exist.
So in the meta.yaml it should be openalea.fspmwheat. As I said that is not mandatory, the CI passed without it, it is only recommended to ensure that the module import works.