Fix deprecated depends_on macos: syntax in generated Homebrew formula#172
Open
defmacro-jam wants to merge 1 commit into
Open
Fix deprecated depends_on macos: syntax in generated Homebrew formula#172defmacro-jam wants to merge 1 commit into
depends_on macos: syntax in generated Homebrew formula#172defmacro-jam wants to merge 1 commit into
Conversation
Homebrew now deprecates having a bare `depends_on :macos` (auto-emitted by GoReleaser for darwin-only targets) alongside a top-level versioned `depends_on :macos => :sequoia`. Wrap the version constraint in an `on_macos` block, which is the form Homebrew's deprecation message recommends, and switch to the blessed `depends_on macos: :sequoia` keyword syntax (the `=> :sequoia` / string ">= :sequoia" forms are both deprecated). Semantics are unchanged: macOS Sequoia or newer. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
softnet.rbformula triggers a Homebrew deprecation warning on every evaluation (e.g. duringbrew update/upgrade):Cause: GoReleaser auto-emits a bare
depends_on :macosfor the darwin-only build targets, andbrews.custom_blockadds a top-level versioneddepends_on :macos => :sequoia. Homebrew (software_spec.rb) now deprecates having both a bare and a versioned macOS dependency at the top level.Fix: wrap the version constraint in an
on_macosblock — the form Homebrew's own deprecation message recommends — and use the blesseddepends_on macos: :sequoiakeyword. (The=> :sequoiahash-rocket and the">= :sequoia"string forms are both independently deprecated.) Semantics are unchanged: macOS Sequoia or newer.Verification (Homebrew 4.x): the current formula reproduces the warning when loaded; the patched form loads clean with no deprecation.
🤖 Generated with Claude Code