[codex] Restore arm64 macOS release packaging#160
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 237f7b505c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rz-openai
changed the title
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c08ee78b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
package:mac:releaseselect arm64 regardless of the Node process architectureFailure
Snap-O Network Inspector.app: code object is not signed at allTesting
npm run package:mac:releasenpm run format:checknpm run lintnpm run typechecknpm testsnap-o-releasesigning settings:xcodebuild -project Snap-O.xcodeproj -scheme Snap-O -configuration Release -archivePath /tmp/snap-o-arm64-deterministic.xcarchive -derivedDataPath /tmp/snap-o-arm64-deterministic-derived -sdk macosx COMPILER_INDEX_STORE_ENABLE=NO CODE_SIGN_STYLE=Manual CODE_SIGN_IDENTITY=- "OTHER_CODE_SIGN_FLAGS=--options runtime" archiveSnap-O,snapo, andSnap-O Network Inspectorexecutables are all arm64Checklist