fix: loading after ActiveSupport 6 subclass extensions - #346
Conversation
Generation metadata: ewogICJjb25maWd1cmF0aW9uX2NoZWNrcG9pbnRfc2hhIjogIjQ2N2Y1OThhOWIyYmIwNzM1Y2Y0NWMwMTQ0M2YwYTg0YjI2ZWEwM2IiLAogICJnZW5lcmF0ZWRfYmFzZWxpbmVfc2hhMjU2IjogIjdmYWM2NTI4ZGU4MGMzYzViMTY0YTg3N2I1MjY3NjAzYzE4ZDZjODc3NDllMTAwNDI5MmY0ZjlhZDE1YThiOGIiLAogICJnZW5lcmF0aW9uX2lkIjogIjYwY2FiYzdmLTMzYWQtNDEwNy04YzM5LTgxNTAwYTZjZDlhMSIsCiAgImlucHV0X2J1bmRsZV9kaWdlc3QiOiAiNzBkM2ZhYTI4YWEwMGIyNDFlNmFlNThiMDE5OTJlZGQ2YTVkNGJiNTUyYTI2Yzc4MTVjZGFiNGIzNjk5ZmZhNiIsCiAgImxhbmd1YWdlIjogInJ1YnkiLAogICJwcmV2aW91c19nZW5lcmF0aW9uX2lkIjogbnVsbCwKICAicHVibGljX2Jhc2VsaW5lX2NvbW1pdCI6ICI0OTFlYWNiZTU5YWE3NzU4NjczMWE3OTI5ZjQ4N2E0ZGNkNmY3MTEzIiwKICAic291cmNlX2JyYW5jaCI6ICJhcGNoYS1ncHQtNS01IiwKICAidGFyZ2V0IjogIm9wZW5haS1ydWJ5Igp9Cg==
…h/ruby-activesupport-subclasses
Generation metadata: ewogICJjb25maWd1cmF0aW9uX2NoZWNrcG9pbnRfc2hhIjogImZlZDE0ZTNhYTIxODFkNzFhNGQzYzRhYzIyY2RkNzlkNmFkYTU3ZjQiLAogICJnZW5lcmF0ZWRfYmFzZWxpbmVfc2hhMjU2IjogIjFkYzg1NDU4NzY2YTBjZTc0ZGI3MmNkZGNjZjViN2NiNDNkMjljMDcxMmMzNzU5MWM0NzMzZDUwNTYwMmIwNjciLAogICJnZW5lcmF0aW9uX2lkIjogIjA1ZWYxMmIzLTIwNjgtNDBlMi05NDljLWJlMTIwN2M4NTgxOSIsCiAgImlucHV0X2J1bmRsZV9kaWdlc3QiOiAiYTZjYTdjOWI4MDIwOWNjZDhiNzUxOTBkMTNkNWNkNzczZjBhYzdjODNiODQ0YzJhMzE5NDMxNTYwODUxOWEwNSIsCiAgImxhbmd1YWdlIjogInJ1YnkiLAogICJwcmV2aW91c19nZW5lcmF0aW9uX2lkIjogIjYwY2FiYzdmLTMzYWQtNDEwNy04YzM5LTgxNTAwYTZjZDlhMSIsCiAgInB1YmxpY19iYXNlbGluZV9jb21taXQiOiAiN2ZkNGY2Yzk0YmRhZmI2NjllMjNkZTQ4OTE1ZDQ0NjVlYzAyMDIxNSIsCiAgInNvdXJjZV9icmFuY2giOiAiamJlY2t3aXRoL3J1YnktYWN0aXZlc3VwcG9ydC1zdWJjbGFzc2VzIiwKICAidGFyZ2V0IjogIm9wZW5haS1ydWJ5Igp9Cg==
…h/ruby-activesupport-subclasses
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
HAYDEN-OAI
left a comment
There was a problem hiding this comment.
Reviewed exact head 4965c11 across the full diff, load-order path, BaseModel equality and alias contracts, and generated audit-log schema/runtime/type changes. No substantive correctness, compatibility, security, reliability, concurrency/resource, or maintainability issues found.
Summary
ActiveSupport 6 discovers subclasses with
==.OpenAI::Internal::Type::BaseModeldefines structural equality, so callingBaseModel.subclasseswhile model aliases are still initializing can resolve an alias too early and raiseNameError. The OpenAI-profile bootstrap now discovers direct subclasses throughObjectSpaceand compares superclasses by identity, without modifying ActiveSupport or changingBaseModel#==.This replaces #336, which manually carried only a reduced subset of the generated delta.
Closes #335.
Castiron provenance
84b54ec48a124965c116de69a80456c27ee029a64e0d13404ff0c1e65f76af4a6b652112f2f82f957ffbb59b9dca7fd4f6c94bdafb669e23de48915d4465ec02021505ef12b3-2068-40e2-949c-be1207c85819The branch preserves the Castiron-generated checkpoint and merge history. The final handwritten commit strengthens the subprocess regression test by verifying a representative generated model still receives its
OrHashalias.Compatibility
AuditLogListResponse#sourcefield is additive, optional, and nullable.Validation
mise exec ruby@4.0.6 -- ./scripts/test— 515 runs, 1,692 assertionsmise exec ruby@4.0.6 -- bundle exec rake lint:rubocop— 2,596 files, no offensesmise exec ruby@4.0.6 -- bundle exec rake typecheck:sorbet— no errorsmise exec ruby@4.0.6 -- bundle exec rake validate:rbs— 1,211 filesmise exec ruby@4.0.6 -- bundle exec rake build:gem— succeeded