http: import upstream packfile-URI concurrency fixes - #28
Merged
Conversation
abg-OAI
approved these changes
Aug 8, 2026
ttaylorr-oai
marked this pull request as ready for review
August 8, 2026 17:43
ttaylorr-oai
force-pushed
the
tb/codex/packfile-uri-concurrency
branch
from
August 8, 2026 17:57
c4244bd to
4cc8b32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This carries Ted Nyman's six-commit
tn/packfile-uri-concurrencytopic, as merged into Git'sjchat 8004c4e. The topic is rebased onto the currentopenai/gitmasterso Codex v3 can infermasteras its lane boundary. Downstream head is4cc8b3223b; the upstream source tip is c4244bd.git range-diffreports all six patches unchanged.The series fixes resumed and concurrent packfile-URI downloads: it accepts a complete partial pack after HTTP 416, avoids concurrent append corruption, keeps indexing safe across unlink/Windows sharing behavior, and preserves a pre-existing
.keepfile. It also fixes the--index-pack-argdocumentation and a double-close in the HTTP pack path.Upstream commits:
http-fetch: correct --index-pack-arg documentationhttp: avoid closing index-pack input twicehttp: accept HTTP 416 for complete partial packshttp: avoid concurrent appends to partial packshttp: permit unlinking partial packs on Windowsfetch-pack: accept "pack" output for packfile URIsValidation:
make -j8 DEVELOPER=1 git git-http-fetch git-http-pushGIT_TEST_HTTPD=true make -C t t5550-http-fetch-dumb.sh(63/63)GIT_TEST_HTTPD=true make -C t t5702-protocol-v2.sh(86/86)git range-diff 55526a1..c4244bd origin/master..HEAD(six patch-equivalent commits)git diff --check origin/master..HEADgit merge-tree --write-tree origin/codex HEADThis PR is the reviewed topic artifact. The Codex v3 plan/rebuild flow, rather than a direct merge of this PR, enrolls it into
codex.