docs(adr): factcheck + proofread corrections (ADR-1, ADR-2) - #13
Merged
Conversation
ADR-1 (agent-lifecycle): - `docker pause` is the cgroup freezer, not SIGSTOP - ENI is provisioned in PROVISIONING, not ACTIVATING (image pull + secret inject) - scope the health axis's "in-sync" to lease/probe/authz, not version-skew (version-skew is healthy → Paused), resolving the overload vs Unhealthy - note Stopping vs Stopped are split by a 5th signal (process liveness/terminality), not the four discriminators - "agents do control" (drop stray "the"); spacing nit ADR-2 (deployment-control-plane): - k8s `desired` is spec-sourced (.spec.replicas), not a .status counter - add the missing `Starting` row to the 6-state ⇄ k8s mapping - soften glossary phase ≈ Pod .status.phase (ours is derived; see §4 traps) - "look before you leap" Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrections from a proofread + fact-check pass over the accepted ADRs on main.
ADR-1 — agent-lifecycle
docker pause= cgroup freezer, not SIGSTOP (the freezer being uncatchable is why the healthcheck stalls).ADR-2 — deployment-control-plane
desiredis spec-sourced (.spec.replicas), not a.statuscounter (service-level in ECS).Startingrow to the 6-state ⇄ k8s mapping (only 5 of 6 were mapped).phase ≈ Pod .status.phase(ours is derived; see §4 traps).All load-bearing technical claims in both ADRs otherwise checked out (ECS DescribeServices/DescribeTasks split, healthStatus UNKNOWN without healthCheck, Terminating≠phase, MCP tool/dry_run semantics, prior-art table). Verified via subagent fact-check with sourcing (k8s API docs, AWS ECS docs).
🤖 Generated with Claude Code