Skip to content

fe: landing page UI #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iSimran2023 wants to merge 2 commits into from
Closed

fe: landing page UI #3665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e72214
fe: landing page UI
iSimran2023 Jun 19, 2026
f5b8dcd
fe: rename Clients to Members, restructure navbar and create member f…
iSimran2023 Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/account-transfers/view-account-transfer/view-account-transfer.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ export class ViewAccountTransferComponent {
}

transferToClient(toClient: any): string {
return `/#/clients/${toClient.id}`;
return `/#/members/${toClient.id}`;
}

transferToAccount(toClient: any, toAccount: any): string {
return `/#/clients/${toClient.id}/savings-accounts/${toAccount.id}`;
return `/#/members/${toClient.id}/savings-accounts/${toAccount.id}`;
}

goBack(): void {
Expand Down
2 changes: 1 addition & 1 deletion src/app/app-routing.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const routes: Routes = [
loadChildren: () => import('./centers/centers.module').then((m) => m.CentersModule)
},
{
path: 'clients',
path: 'members',
loadChildren: () => import('./clients/clients.module').then((m) => m.ClientsModule)
},
{
Expand Down
140 changes: 69 additions & 71 deletions src/app/clients/client-stepper/client-general-step/client-general-step.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@

<form [formGroup]="createClientForm">
<div class="layout-row-wrap gap-2px responsive-column">
<mat-form-field class="flex-fill flex-23">
<!-- Row 1: Office, Legal Form, External Id, First Name / Middle Name (or Full Name for Entity) -->
<mat-form-field class="flex-20">
Comment on lines +11 to +12

@coderabbitai coderabbitai Bot Jun 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Check that flex-* and margin-v classes use SCSS variables and follow 8px grid

echo "=== Checking flex-* utility class definitions ==="
rg -n "\.flex-(10|15|20|23|30|40|98)" --type=scss -C2

echo -e "\n=== Checking margin-v class definition ==="
rg -n "\.margin-v" --type=scss -C2

echo -e "\n=== Checking SCSS variable usage in src/main.scss ==="
cat src/main.scss | head -50

echo -e "\n=== Checking SCSS variable usage in src/theme/mifosx-theme.scss ==="
cat src/theme/mifosx-theme.scss | head -50

Repository: openMF/web-app

Length of output: 3511

🏁 Script executed:

#!/bin/bash
# Search for where flex-* classes are defined
echo "=== Searching for flex-10, flex-15, flex-20 class definitions ==="
rg "flex-(10|15|20|23|30|40|98)" -n

echo -e "\n=== Searching for margin-v class definition ==="
rg "margin-v" -n

echo -e "\n=== Checking for utility/helper SCSS files ==="
find . -name "*helper*" -o -name "*util*" -o -name "*grid*" | head -20

Repository: openMF/web-app

Length of output: 50371

🏁 Script executed:

#!/bin/bash
# Read the actual SCSS definitions for flex-* classes
echo "=== Checking flex-10 definition (around line 275) ==="
sed -n '270,285p' src/main.scss

echo -e "\n=== Checking flex-15 definition (around line 287) ==="
sed -n '285,295p' src/main.scss

echo -e "\n=== Checking flex-20 definition (around line 299) ==="
sed -n '295,310p' src/main.scss

echo -e "\n=== Checking flex-30 definition (around line 323) ==="
sed -n '318,335p' src/main.scss

echo -e "\n=== Checking flex-40 definition (around line 347) ==="
sed -n '342,355p' src/main.scss

echo -e "\n=== Checking flex-98 definition (around line 473) ==="
sed -n '468,480p' src/main.scss

echo -e "\n=== Searching for margin-v class ==="
rg "margin-v" -n src/main.scss

Repository: openMF/web-app

Length of output: 1145

Verify responsive sizing classes use SCSS variables instead of hardcoded values.

Multiple form fields use responsive sizing classes (flex-20, flex-15, flex-40, flex-23, flex-30, flex-98, flex-10) that currently contain hardcoded percentage values (e.g., flex: 0 0 20%) in src/main.scss. Per coding guidelines, these should leverage SCSS variables from src/main.scss or src/theme/mifosx-theme.scss rather than explicit hardcoded values.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/app/clients/client-stepper/client-general-step/client-general-step.component.html`
around lines 11 - 12, The responsive sizing classes (flex-20, flex-15, flex-40,
flex-23, flex-30, flex-98, flex-10) used in client-general-step.component.html
are currently defined in src/main.scss with hardcoded percentage values. Replace
these hardcoded values with SCSS variables by either creating new variables in
src/main.scss or src/theme/mifosx-theme.scss for each flex percentage value,
then update the class definitions to reference these variables instead of the
explicit percentage values. Ensure all responsive sizing classes used throughout
the component are updated consistently.

Source: Coding guidelines

<mat-label>{{ 'labels.inputs.Office' | translate }}</mat-label>
<mat-select required formControlName="officeId">
@for (office of officeOptions; track office) {
Expand All @@ -25,7 +26,7 @@
}
</mat-form-field>

<mat-form-field class="flex-fill flex-23">
<mat-form-field class="flex-15">
<mat-label>{{ 'labels.inputs.Legal Form' | translate }}</mat-label>
<mat-select required formControlName="legalFormId">
@for (legalForm of legalFormOptions; track legalForm) {
Expand All @@ -36,7 +37,7 @@
</mat-select>
</mat-form-field>

<mat-form-field class="flex-fill flex-23">
<mat-form-field class="flex-20">
<mat-label>{{ 'labels.inputs.External Id' | translate }}</mat-label>
<input matInput formControlName="externalId" />
@if (!externalNationalIdService.isLoading && externalNationalIdService.statusMessageKey) {
Expand All @@ -55,7 +56,7 @@
</mat-form-field>

@if (createClientForm.get('fullname')) {
<mat-form-field class="flex-48">
<mat-form-field class="flex-40">
<mat-label>
{{ 'labels.inputs.' + getDateLabel(createClientForm.value.legalFormId, ['Name', 'Entity Name']) | translate }}
</mat-label>
Expand All @@ -75,65 +76,62 @@
</mat-form-field>
}

@if (createClientForm.get('firstname') || createClientForm.get('middlename') || createClientForm.get('lastname')) {
<div class="name-fields-row">
@if (createClientForm.get('firstname')) {
<mat-form-field class="name-field first-name">
<mat-label>{{ 'labels.inputs.First Name' | translate }}</mat-label>
<input matInput required formControlName="firstname" />
@if (createClientForm.controls.firstname.hasError('required')) {
<mat-error>
{{ 'labels.inputs.Client first name' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong>
</mat-error>
}
@if (createClientForm.controls.firstname.hasError('pattern')) {
<mat-error>
{{ 'labels.inputs.Client first name' | translate }}
<strong>{{ 'labels.inputs.cannot' | translate }}</strong>
{{ 'labels.commons.begin with a special character or number' | translate }}
</mat-error>
}
</mat-form-field>
@if (createClientForm.get('firstname')) {
<mat-form-field class="flex-20">
<mat-label>{{ 'labels.inputs.First Name' | translate }}</mat-label>
<input matInput required formControlName="firstname" />
@if (createClientForm.controls.firstname.hasError('required')) {
<mat-error>
{{ 'labels.inputs.Client first name' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong>
</mat-error>
}
@if (createClientForm.get('middlename')) {
<mat-form-field class="name-field middle-name">
<mat-label>{{ 'labels.inputs.Middle Name' | translate }}</mat-label>
<input matInput formControlName="middlename" />
@if (createClientForm.controls.middlename.hasError('pattern')) {
<mat-error>
{{ 'labels.inputs.Client middle name' | translate }}
<strong>{{ 'labels.inputs.cannot' | translate }}</strong>
{{ 'labels.commons.begin with a special character or number' | translate }}
</mat-error>
}
</mat-form-field>
@if (createClientForm.controls.firstname.hasError('pattern')) {
<mat-error>
{{ 'labels.inputs.Client first name' | translate }}
<strong>{{ 'labels.inputs.cannot' | translate }}</strong>
{{ 'labels.commons.begin with a special character or number' | translate }}
</mat-error>
}
@if (createClientForm.get('lastname')) {
<mat-form-field class="name-field last-name">
<mat-label>{{ 'labels.inputs.Last Name' | translate }}</mat-label>
<input matInput required formControlName="lastname" />
@if (createClientForm.controls.lastname.hasError('required')) {
<mat-error>
{{ 'labels.inputs.Client last name' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong>
</mat-error>
}
@if (createClientForm.controls.lastname.hasError('pattern')) {
<mat-error>
{{ 'labels.inputs.Client last name' | translate }}
<strong>{{ 'labels.inputs.cannot' | translate }}</strong>
{{ 'labels.commons.begin with a special character or number' | translate }}
</mat-error>
}
</mat-form-field>
</mat-form-field>
}

@if (createClientForm.get('middlename')) {
<mat-form-field class="flex-20">
<mat-label>{{ 'labels.inputs.Middle Name' | translate }}</mat-label>
<input matInput formControlName="middlename" />
@if (createClientForm.controls.middlename.hasError('pattern')) {
<mat-error>
{{ 'labels.inputs.Client middle name' | translate }}
<strong>{{ 'labels.inputs.cannot' | translate }}</strong>
{{ 'labels.commons.begin with a special character or number' | translate }}
</mat-error>
}
</div>
</mat-form-field>
}

<mat-divider></mat-divider>
<!-- Row 2: Last Name, Date of Birth, Gender, Staff, Is Staff? -->
@if (createClientForm.get('lastname')) {
<mat-form-field class="flex-20">
<mat-label>{{ 'labels.inputs.Last Name' | translate }}</mat-label>
<input matInput required formControlName="lastname" />
@if (createClientForm.controls.lastname.hasError('required')) {
<mat-error>
{{ 'labels.inputs.Client last name' | translate }} {{ 'labels.commons.is' | translate }}
<strong>{{ 'labels.commons.required' | translate }}</strong>
</mat-error>
}
@if (createClientForm.controls.lastname.hasError('pattern')) {
<mat-error>
{{ 'labels.inputs.Client last name' | translate }}
<strong>{{ 'labels.inputs.cannot' | translate }}</strong>
{{ 'labels.commons.begin with a special character or number' | translate }}
</mat-error>
}
</mat-form-field>
}
Comment on lines +79 to +132

@coderabbitai coderabbitai Bot Jun 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify TypeScript component manages firstname/middlename/lastname form controls based on legalFormId

echo "=== Checking component form control management ==="
ast-grep --pattern $'addControl($$$) {
  $$$
}'

echo -e "\n=== Checking for legalFormId-based control logic ==="
rg -n "legalFormId|firstname|middlename|lastname" src/app/clients/client-stepper/client-general-step/client-general-step.component.ts -A3 -B3

echo -e "\n=== Checking if name-fields-row CSS was removed ==="
rg -n "name-fields-row" --type=scss

Repository: openMF/web-app

Length of output: 2271

🏁 Script executed:

#!/bin/bash
# Find and check CSS/SCSS files for name-fields-row and flex-20 definitions
echo "=== Searching for name-fields-row in CSS/SCSS files ==="
find src -type f \( -name "*.scss" -o -name "*.css" \) -exec grep -l "name-fields-row\|flex-20" {} \;

echo -e "\n=== Checking component-specific SCSS file ==="
ls -la src/app/clients/client-stepper/client-general-step/ | grep -E "\.(scss|css)$"

echo -e "\n=== Checking for flex-20 definition in theme files ==="
grep -r "flex-20" src/theme/ src/main.scss 2>/dev/null || echo "Not found in theme files"

echo -e "\n=== Checking for grid/flex utilities in main styles ==="
rg "flex-20|name-fields-row" src/main.scss src/styles.scss 2>/dev/null || echo "Pattern not found"

Repository: openMF/web-app

Length of output: 527

🏁 Script executed:

#!/bin/bash
# Check the actual CSS definitions for name-fields-row and related styling
echo "=== Checking name-fields-row definition in component SCSS ==="
cat -n src/app/clients/client-stepper/client-general-step/client-general-step.component.scss

echo -e "\n=== Checking name-fields-row definition in main.scss ==="
rg -A5 "\.name-fields-row" src/main.scss

echo -e "\n=== Checking flex-20 definition ==="
rg -A3 "\.flex-20" src/main.scss

Repository: openMF/web-app

Length of output: 3441

Fix CSS layout issues caused by removing the name-fields-row wrapper container.

The refactoring removed the name-fields-row wrapper div, which had essential CSS rules that are now lost:

  • The flex container's gap: 8px no longer applies horizontally between name fields
  • Media query rules that adjusted layout for screens ≤768px are no longer active
  • The proportional flex sizing (flex: 1.2 for first/last name, flex: 1 for middle name) is replaced by uniform flex-20 (20% width), changing the field proportions
  • Sibling margin rules that added top spacing to elements following the name fields group are no longer applied

While the TypeScript component correctly manages the form control lifecycle (adding/removing firstname, middlename, lastname based on legalFormId), the HTML refactoring breaks the responsive design and flex layout. Either restore the wrapper container with its CSS or apply equivalent styling directly to the individual mat-form-field elements.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/app/clients/client-stepper/client-general-step/client-general-step.component.html`
around lines 79 - 132, The removal of the name-fields-row wrapper container
eliminated essential CSS rules that controlled spacing and responsive layout for
the firstname, middlename, and lastname form fields. To fix this, either restore
the wrapper div around the three mat-form-field elements (for firstname,
middlename, and lastname) with its original CSS rules including the gap property
for horizontal spacing and media queries for responsive behavior, or apply
equivalent CSS classes/styles directly to each mat-form-field element to achieve
the same layout effect with proper spacing between fields and responsive
adjustments for screens 768px and below.


<mat-form-field class="flex-48" (click)="dateOfBirthDatePicker.open()">
<mat-form-field class="flex-20" (click)="dateOfBirthDatePicker.open()">
<mat-label>
{{
'labels.inputs.' + getDateLabel(createClientForm.value.legalFormId, ['Date of Birth', 'Incorporation Date'])
Expand Down Expand Up @@ -191,7 +189,7 @@
}

@if (createClientForm.value.legalFormId === LegalFormId.PERSON) {
<mat-form-field class="flex-48">
<mat-form-field class="flex-15">
<mat-label>{{ 'labels.inputs.Gender' | translate }}</mat-label>
<mat-select formControlName="genderId">
@for (gender of genderOptions; track gender) {
Expand All @@ -203,7 +201,7 @@
</mat-form-field>
}

<mat-form-field class="flex-48">
<mat-form-field class="flex-23">
<mat-label>{{ 'labels.inputs.Staff' | translate }}</mat-label>
<mat-select formControlName="staffId">
@for (staff of staffOptions; track staff) {
Expand All @@ -215,19 +213,20 @@
</mat-form-field>

@if (createClientForm.value.legalFormId === LegalFormId.PERSON) {
<mat-checkbox class="flex-48 margin-v" labelPosition="before" formControlName="isStaff">
<mat-checkbox class="flex-15 margin-v" labelPosition="before" formControlName="isStaff">
{{ 'labels.inputs.Is staff' | translate }}?
</mat-checkbox>
}

<mat-divider class="flex-98"></mat-divider>

<mat-form-field class="flex-48">
<!-- Row 3: Mobile No, Email Address, Client Type, Client Classification -->
<mat-form-field class="flex-20">
<mat-label>{{ 'labels.inputs.Mobile No' | translate }}</mat-label>
<input matInput type="text" formControlName="mobileNo" />
</mat-form-field>

<mat-form-field class="flex-48">
<mat-form-field class="flex-30">
<mat-label>{{ 'labels.inputs.Email Address' | translate }}</mat-label>
<input matInput formControlName="emailAddress" />
@if (createClientForm.controls.emailAddress.errors?.email) {
Expand All @@ -237,7 +236,7 @@
}
</mat-form-field>

<mat-form-field class="flex-48">
<mat-form-field class="flex-23">
<mat-label>{{ 'labels.inputs.Client Type' | translate }}</mat-label>
<mat-select formControlName="clientTypeId">
@for (clientType of clientTypeOptions; track clientType) {
Expand All @@ -248,7 +247,7 @@
</mat-select>
</mat-form-field>

<mat-form-field class="flex-48">
<mat-form-field class="flex-23">
<mat-label>{{ 'labels.inputs.Client Classification' | translate }}</mat-label>
<mat-select formControlName="clientClassificationId">
@for (clientClassification of clientClassificationTypeOptions; track clientClassification) {
Expand All @@ -259,7 +258,8 @@
</mat-select>
</mat-form-field>

<mat-form-field class="flex-48" (click)="submittedOnDatePicker.open()">
<!-- Row 4: Submitted On, Active?, Activation Date, Open Savings Account?, Savings Product -->
<mat-form-field class="flex-20" (click)="submittedOnDatePicker.open()">
<mat-label>{{ 'labels.inputs.Submitted On' | translate }}</mat-label>
<input
matInput
Expand All @@ -273,14 +273,12 @@
<mat-datepicker #submittedOnDatePicker></mat-datepicker>
</mat-form-field>

<br />

<mat-checkbox labelPosition="before" formControlName="active" class="margin-v flex-48">
<mat-checkbox labelPosition="before" formControlName="active" class="margin-v flex-10">
{{ 'labels.inputs.Active' | translate }}?
</mat-checkbox>

@if (createClientForm.contains('activationDate')) {
<mat-form-field class="flex-48" (click)="activatedOnDatePicker.open()">
<mat-form-field class="flex-20" (click)="activatedOnDatePicker.open()">
<mat-label>{{ 'labels.inputs.Activation Date' | translate }}</mat-label>
<input
matInput
Expand All @@ -301,12 +299,12 @@
</mat-form-field>
}

<mat-checkbox labelPosition="before" formControlName="addSavings" class="margin-v flex-48">
<mat-checkbox labelPosition="before" formControlName="addSavings" class="margin-v flex-10">
{{ 'labels.inputs.Open Savings Account' | translate }}?
</mat-checkbox>

@if (createClientForm.contains('savingsProductId')) {
<mat-form-field class="flex-48">
<mat-form-field class="flex-20">
<mat-label>{{ 'labels.inputs.Savings Product' | translate }}</mat-label>
<mat-select required formControlName="savingsProductId">
@for (product of savingProductOptions; track product) {
Expand Down
12 changes: 12 additions & 0 deletions src/app/clients/client-stepper/client-general-step/client-general-step.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,18 @@ form {
}
}

.flex-10 {
flex: 0 0 10%;
}

.flex-15 {
flex: 0 0 15%;
}

.flex-22 {
flex: 0 0 22%;
}

mat-form-field {
margin-bottom: 8px;
}
Expand Down
4 changes: 2 additions & 2 deletions src/app/clients/clients-routing.module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ const routes: Routes = [
},
{
path: 'create',
data: { title: 'Create Client', breadcrumb: 'Create Client', routeParamBreadcrumb: false },
data: { title: 'Create Member', breadcrumb: 'Create Member', routeParamBreadcrumb: false },

@coderabbitai coderabbitai Bot Jun 21, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if "Create Member" translation key exists in translation files

rg -n "Create Member" src/assets/translations/ --type json

Repository: openMF/web-app

Length of output: 40

🏁 Script executed:

# First, check the exact content of the routing file around line 71
sed -n '65,85p' src/app/clients/clients-routing.module.ts

Repository: openMF/web-app

Length of output: 832

🏁 Script executed:

# List translation files to understand structure
find src/assets/translations/ -type f -name "*.json" | head -20

Repository: openMF/web-app

Length of output: 513

🏁 Script executed:

# Search for both "Create Member" and "Create Client" to understand the pattern
rg "Create (Member|Client)" src/assets/translations/ -t json --max-count 20

Repository: openMF/web-app

Length of output: 2038

🏁 Script executed:

# Check if "Members View" translation key exists
rg "Members View" src/assets/translations/ -t json

Repository: openMF/web-app

Length of output: 131

🏁 Script executed:

# Check if there are any "Member" keys at all in translation files
rg "Member" src/assets/translations/ -t json | head -20

Repository: openMF/web-app

Length of output: 1673

🏁 Script executed:

# Check one translation file to understand the structure
cat src/assets/translations/en-US.json | grep -A2 -B2 "Create Client"

Repository: openMF/web-app

Length of output: 463

Use the correct i18n translation keys for route metadata.

The route data uses string literals that don't exist as translation keys. Replace 'Create Member' with 'Create Client' and 'Members View' (on line 81) with 'Clients View' to match the existing translation keys in the translation files. The breadcrumb component requires these to be actual translation keys for proper i18n lookup.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/app/clients/clients-routing.module.ts` at line 71, In the
clients-routing.module.ts file, the route data configuration contains incorrect
i18n translation key string literals that don't match the actual translation
keys in the translation files. Update the title and breadcrumb properties in the
route metadata: replace 'Create Member' with 'Create Client' on line 71, and
replace 'Members View' with 'Clients View' on line 81. These corrections will
ensure the breadcrumb component can properly perform i18n lookup using the
existing translation keys.

Source: Learnings

component: CreateClientComponent,
resolve: {
clientAddressFieldConfig: ClientAddressFieldConfigurationResolver,
Expand All @@ -78,7 +78,7 @@ const routes: Routes = [
{
path: ':clientId',
component: ClientsViewComponent,
data: { title: 'Clients View', routeParamBreadcrumb: 'clientId' },
data: { title: 'Members View', routeParamBreadcrumb: 'clientId' },
resolve: {
clientViewData: ClientViewResolver,
clientTemplateData: ClientTemplateResolver,
Expand Down
4 changes: 2 additions & 2 deletions src/app/clients/clients-view/clients-view.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export class ClientsViewComponent implements OnInit {
*/
reload() {
const url: string = this.router.url;
this.router.navigateByUrl(`/clients`, { skipLocationChange: true }).then(() => this.router.navigate([url]));
this.router.navigateByUrl(`/members`, { skipLocationChange: true }).then(() => this.router.navigate([url]));
}

/**
Expand All @@ -286,7 +286,7 @@ export class ClientsViewComponent implements OnInit {
}
if (response.delete) {
this.clientsService.deleteClient(this.clientViewData.id).subscribe(() => {
this.router.navigate(['/clients'], { relativeTo: this.route });
this.router.navigate(['/members'], { relativeTo: this.route });
});
}
});
Expand Down
2 changes: 1 addition & 1 deletion src/app/collaterals/view-collateral/view-collateral.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ <h3>{{ 'labels.heading.Transaction Details' | translate }}</h3>
</ng-container>

<!-- <tr mat-header-row *matHeaderRowDef="clientMemberColumns"></tr>
<tr mat-row *matRowDef="let row; columns: clientMemberColumns;" [routerLink]="['/clients', row.id, 'loans-accounts', 'create']" class="select-row"></tr> -->
<tr mat-row *matRowDef="let row; columns: clientMemberColumns;" [routerLink]="['/members', row.id, 'loans-accounts', 'create']" class="select-row"></tr> -->
<tr mat-header-row *matHeaderRowDef="collateralColumns"></tr>
<tr mat-row *matRowDef="let row; columns: collateralColumns"></tr>
</table>
Expand Down
14 changes: 0 additions & 14 deletions src/app/core/authentication/authentication.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export class AuthenticationService {
*/
private storage: Storage = sessionStorage;
private credentials: Credentials;
private dialogShown = false;
private authMode: AuthMode = AuthMode.Basic;

/** Promise that resolves once the OIDC discovery document has been loaded. */
Expand Down Expand Up @@ -372,7 +371,6 @@ export class AuthenticationService {

this.authenticationInterceptor.removeAuthorization();
this.setCredentials();
this.resetDialog();
this.userLoggedIn$.next(false);

if (this.authMode === AuthMode.OIDC) {
Expand Down Expand Up @@ -481,18 +479,6 @@ export class AuthenticationService {
return this.http.get('/twofactor');
}

showDialog() {
this.dialogShown = true;
}

resetDialog() {
this.dialogShown = false;
}

hasDialogBeenShown() {
return this.dialogShown;
}

/**
* Requests OTP to be sent via the given delivery method.
* @param {any} deliveryMethod Delivery method for the OTP.
Expand Down
1 change: 0 additions & 1 deletion src/app/core/shell/sidenav/sidenav.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
<div class="navigation-panel layout-column">
<!-- TODO: Allow customization by organization -->
<div class="app-brand" [routerLink]="['/home']">
<img src="assets/images/MifosX_logo.png" alt="app-logo" class="app-logo" />
<span #logo class="app-logo-text text-muted">{{ 'APP_NAME' | translate }}</span>
</div>

Expand Down
Loading