Update weaver so that it ONLY imports, even when using the flag.#1442
Open
jsuereth wants to merge 3 commits into
Open
Update weaver so that it ONLY imports, even when using the flag.#1442jsuereth wants to merge 3 commits into
jsuereth wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1442 +/- ##
=======================================
- Coverage 82.2% 82.1% -0.1%
=======================================
Files 125 125
Lines 10241 10247 +6
=======================================
- Hits 8424 8423 -1
- Misses 1817 1824 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@jsuereth I tried this locally and it's consistent. So, good to go once you've fixed clippy. |
lmolkova
approved these changes
May 20, 2026
Member
lmolkova
left a comment
lmolkova
left a comment
There was a problem hiding this comment.
Tried out open-telemetry/opentelemetry-python-genai#55 as an alternative to --include-unreferenced and it also works nicely.
Even without config, this PR does not break old behavior, just changes how it's implemented, so we should be good to go!
Member
There was a problem hiding this comment.
can you please add a changelog record?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.