Prevent abort() call while parsing an input strings with too deep nestings - #1710
Open
smallSwed wants to merge 1 commit into
Open
Prevent abort() call while parsing an input strings with too deep nestings#1710smallSwed wants to merge 1 commit into
smallSwed wants to merge 1 commit into
Conversation
…h too deep nested objects/arrays when JSON_USE_EXCEPTION=0
Author
|
I wasn't sure to how to rework the error recovery, but maybe in this case the parser may better to skip the whole recovering all together. ...
current_ = end_; // short circuit the parsing to prevent error recovery
return addError(
... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
JSON_USE_EXCEPTIONset0jsoncpp should not abort when the input string contains object/array which is exceeds the stackLimit.The caller unable to validate that the input string exceeds the nesting stackLimit without parsing the json, so abort is a bad response for this case.
When the
JSON_USE_EXCEPTIONis1then the caller can catch the thrown exception and handle the issue how they want it.With this change I intend to make the non-exception variant case fail gracefully too and handle-able.