Skip to content

Conversation

@Rohit0301
Copy link
Contributor

@Rohit0301 Rohit0301 commented Jan 16, 2026

Describe your changes:

Fixes

I worked on ... because ...

Screenshot 2026-01-17 at 12 33 50 AM

Summary by Gitar

  • Test setup fix:
    • Creates conversation thread in ActivityFeed.spec.ts:608 to ensure feed has data before test runs
  • Fixed flaky test:
    • Ensures "Chinese character encoding" test has activity feed entries when navigating to activity feed page

This will update automatically on new commits.


Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Rohit0301 Rohit0301 self-assigned this Jan 16, 2026
@Rohit0301 Rohit0301 requested a review from a team as a code owner January 16, 2026 13:34
@Rohit0301 Rohit0301 added safe to test Add this label to run secure Github workflows on PRs e2e This will trigger e2e test workflows To release Will cherry-pick this PR into the release branch labels Jan 16, 2026
karanh37
karanh37 previously approved these changes Jan 16, 2026
harsh-vador
harsh-vador previously approved these changes Jan 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
65.99% (53814/81549) 44.03% (27012/61349) 47.85% (8464/17688)

Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need clear screenshot of 10 time runs

@gitar-bot
Copy link

gitar-bot bot commented Jan 18, 2026

🔍 CI failure analysis for 7a15236: ActivityFeed test passing on shard (3,6). PR fix successful across shards. Failures unrelated to PR changes.

CI Analysis - Shard (3, 6)

Previous Analysis Context

Previous analysis on shard (2, 6) confirmed that the ActivityFeed Chinese encoding test was passing consistently with 505+ tests passing, and the PR's fix (creating conversation threads instead of just adding descriptions) successfully resolved the flaky test.

Current Run - Shard (3, 6)

Test Results:

  • 500 tests passed
  • 1 failed
  • ⚠️ 10 flaky tests

Critical Finding

The ActivityFeed test continues to pass on this shard as well.

The ActivityFeed Chinese encoding test (the subject of this PR) is NOT appearing in any failure logs for shard (3, 6), confirming the fix remains stable across different test shards.

Failing/Flaky Tests (Unrelated to PR)

The failures observed are in completely different areas:

  • ExploreDiscovery - search suggestions
  • Metric - metric expression updates
  • ObservabilityAlerts - pipeline alerts
  • ServiceForm - UI overflow handling

These test failures are in modules that have no connection to the ActivityFeed functionality or the Playwright test file modified in this PR (ActivityFeed.spec.ts).

Conclusion

The PR's fix is working correctly across multiple CI shards. The ActivityFeed Chinese encoding issue has been resolved. All observed CI failures are infrastructure-related flakiness in unrelated test areas, not caused by the changes in this PR.

Code Review ✅ Approved

Clean fix for a flaky test. The change ensures activity feed data exists by creating a conversation thread during test setup, with proper ordering of async operations.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off Gitar will not commit updates to this branch.
Display: compact Hiding non-applicable rules.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs)

@sonarqubecloud
Copy link

@Rohit0301 Rohit0301 closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants