-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: Fixed activity feed chinese encoding playwright #25344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ShaileshParmar11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need clear screenshot of 10 time runs
7725b43
🔍 CI failure analysis for 7a15236: ActivityFeed test passing on shard (3,6). PR fix successful across shards. Failures unrelated to PR changes.CI Analysis - Shard (3, 6)Previous Analysis ContextPrevious analysis on shard (2, 6) confirmed that the ActivityFeed Chinese encoding test was passing consistently with 505+ tests passing, and the PR's fix (creating conversation threads instead of just adding descriptions) successfully resolved the flaky test. Current Run - Shard (3, 6)Test Results:
Critical Finding✅ The ActivityFeed test continues to pass on this shard as well. The ActivityFeed Chinese encoding test (the subject of this PR) is NOT appearing in any failure logs for shard (3, 6), confirming the fix remains stable across different test shards. Failing/Flaky Tests (Unrelated to PR)The failures observed are in completely different areas:
These test failures are in modules that have no connection to the ActivityFeed functionality or the Playwright test file modified in this PR ( ConclusionThe PR's fix is working correctly across multiple CI shards. The ActivityFeed Chinese encoding issue has been resolved. All observed CI failures are infrastructure-related flakiness in unrelated test areas, not caused by the changes in this PR. Code Review ✅ ApprovedClean fix for a flaky test. The change ensures activity feed data exists by creating a conversation thread during test setup, with proper ordering of async operations. Tip Comment OptionsAuto-apply is off Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | This comment will update automatically (Docs) |
|



Describe your changes:
Fixes
I worked on ... because ...
Summary by Gitar
ActivityFeed.spec.ts:608to ensure feed has data before test runsThis will update automatically on new commits.
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>