feat: add device info decorator for attributes#66
Conversation
Signed-off-by: Yuki Yamamoto <yymmt3.waste@gmail.com>
7e16039 to
7d9f835
Compare
|
Hey @redryerye, thanks for the PR. I think this is a good idea but we should probably align the attribute names so they can be consistently implemented. FYI @open-feature/technical-steering-committee |
Let me know if there is anything I can help with. |
No, not at the moment. I brought this up in today's Governance meeting, and we all felt like this is a good idea. The main concern is standardizing context attribute naming. We're going to evaluate Segment and OTel to see where there are overlaps. By the looks of it, this PR aligns with Segment's structure. |
|
@nicklasl, how did Confidence define these attribute names? |
Sorry about missing this ping. If we (OF) do a bigger workthrough on the naming, I'm sure we'll align the internal Confidence implementations as well for consistency. |
This PR
Notes
As a user of the SDK, I would like to have a default option in the SDK to add basic attributes (OS info, device info, locale, app info), similar to what Confidence provides.
The changes are mostly based on their implementation.
Since the SDK is targeted to iOS, I believe it would be useful to offer this option :)
How to test
You can add attributes with