Skip to content

Conversation

@marcozabel
Copy link

This PR

This PR addresses open issues from the following PR: #1164

Related Issues

#1164

@marcozabel marcozabel requested review from a team as code owners December 5, 2025 13:51
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @marcozabel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the FeatureFlag component within the React SDK by introducing a more robust value comparison mechanism and clarifying its rendering logic. It specifically addresses how the component behaves when evaluating non-boolean feature flags without an explicit match condition, ensuring more predictable and correct conditional rendering.

Highlights

  • Enhanced Value Comparison: The FeatureFlag component now utilizes a dedicated isEqual utility for comparing flag values, ensuring more accurate and robust checks across different data types.
  • Refined Rendering Logic for Non-Boolean Flags: The component's rendering behavior has been updated to explicitly prevent non-boolean flags from rendering by default if no match prop is provided, leading to more predictable conditional rendering.
  • New Test Coverage: A new test case has been added to validate the updated rendering behavior for non-boolean flags when no match prop is supplied, confirming the intended functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the FeatureFlag component to improve its behavior. The key changes include using a deep equality check (isEqual) for the match prop, making comparisons more robust for object and array flag values. Additionally, the logic for rendering children without a match prop has been corrected to only consider the truthiness of boolean flags, preventing non-boolean flags from being rendered implicitly. A new test case has been added to verify this corrected behavior. My review includes a minor suggestion to improve code style in the new test.

@marcozabel marcozabel changed the title Add Feature Flag Component fat(react): Add Feature Flag Component Dec 5, 2025
@marcozabel marcozabel changed the title fat(react): Add Feature Flag Component feat(react): Add Feature Flag Component Dec 5, 2025
@toddbaert toddbaert merged commit 72d0c62 into open-feature:add-feature-flag-component Dec 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants