chore: update build system requirements in pyproject.toml - #13
Draft
navinkarkera wants to merge 2 commits into
Draft
navinkarkera wants to merge 2 commits into
navinkarkera wants to merge 2 commits into
Conversation
Setuptools PEP 639 migration guide: https://setuptools.pypa.io/en/stable/userguide/license_migration.html
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 89.27% 91.50% +2.22%
==========================================
Files 10 10
Lines 289 400 +111
Branches 21 35 +14
==========================================
+ Hits 258 366 +108
- Misses 27 30 +3
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using the PEP 639 license syntax
This requires setuptools 77 or newer. Without an explicit [build-system], isolated builds may use an older setuptools version and fail while validating project.license.
It is currently failing while migrating wgu-ulmo instance to launchpad.
But turns out that Open edX Ulmo currently constrains setuptools to 69.1.1, so we cannot use the new syntax.
Merge checklist:
Check off if complete or not applicable: