[feature] Implement optional registry versioning - #97
Merged
Conversation
specification.md's "Registry versioning (optional)" section describes appending a version segment to a registry's root url when one is configured, so a registry can introduce breaking changes on a new version without affecting managers still pointed at the root - but nothing implemented it: ConfigRegistry had no version field, and Manager.sync() always called the bare registry url. Flagged (as an explicitly optional/nitpick item) in an internal spec-compliance audit. Adds an optional `version` field to ConfigRegistry, and a registryUrl() helper (helpers/registry.ts) that appends it as a path segment onto the registry root when set, leaving unversioned registries (the common case) untouched. Manager.sync() now requests through registryUrl() instead of the bare url. Updated specification.md's Registries field table to document the new field. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specification.md's "Registry versioning (optional)" section describes appending a version segment to a registry's root url when one is configured, so a registry can introduce breaking changes without affecting managers still pointed at the root — but nothing implemented it:ConfigRegistryhad noversionfield, andManager.sync()always called the bare registry url verbatim. Flagged (as an explicitly optional item) in an internal spec-compliance audit.versionfield toConfigRegistry, and aregistryUrl()helper (helpers/registry.ts) that appends it as a path segment onto the registry root when set, leaving unversioned registries (the common case) untouched.Manager.sync()now requests throughregistryUrl()instead of the bareurl.specification.md's Registries field table to document the new field.Test plan
npm run checkpasses (format, lint, build, tests — 198/198)registryUrl()unit tests: unversioned passthrough, version appended, trailing slash on root handledManager.sync()test asserting the versioned url is what actually gets requested (mockedapiJson)🤖 Generated with Claude Code