Update UI base images for SearchQnA, Text2Image and CodeTrans #2396
Conversation
Signed-off-by: ZePan110 <[email protected]>
|
ℹ️ INFO |
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js base image versions in Docker configurations for CodeGen and CodeTrans UI components from specific Node 20 versions to Node 22.
Changes:
- Upgraded Node.js base images from version 20.x to version 22
- Updated Docker base image specifications to use a non-pinned version tag
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CodeTrans/ui/docker/Dockerfile | Updates base image from node:20.19.0 to node:22 |
| CodeGen/ui/docker/Dockerfile | Updates base image from node:20.11.1 to node:22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Use node 20.19.0 as the base image (required for [email protected] compatibility) | ||
| FROM node:20.19.0 | ||
| # Use node 22 as the base image (required for [email protected] compatibility) | ||
| FROM node:22 |
There was a problem hiding this comment.
Using an unpinned version tag (node:22) in production Dockerfiles is not recommended. This can lead to non-reproducible builds as the underlying image may change over time. Consider pinning to a specific patch version (e.g., node:22.0.0) or at minimum a minor version (e.g., node:22.0) to ensure build consistency and predictability.
| FROM node:22 | |
| FROM node:22.0 |
CodeGen/ui/docker/Dockerfile
Outdated
| # Use node 20.11.1 as the base image | ||
| FROM node:20.11.1 | ||
| # Use node 22 as the base image | ||
| FROM node:22 |
There was a problem hiding this comment.
Using an unpinned version tag (node:22) in production Dockerfiles is not recommended. This can lead to non-reproducible builds as the underlying image may change over time. Consider pinning to a specific patch version (e.g., node:22.0.0) or at minimum a minor version (e.g., node:22.0) to ensure build consistency and predictability.
| FROM node:22 | |
| FROM node:22.0.0 |
for more information, see https://pre-commit.ci
pre-commit-ci
bot
requested review from
chensuyue,
ftian1,
lkk12014402,
minmin-intel and
rbrugaro
as code owners
…est to 1.22.2-32 Signed-off-by: ZePan110 <[email protected]>
…enAIExamples into update/2baseimage Signed-off-by: ZePan110 <[email protected]>
|
ℹ️ INFO |
Signed-off-by: ZePan110 <[email protected]>
|
ℹ️ INFO |
ZePan110
changed the title
Description
Update UI base images for SearchQnA, Text2Image and CodeTrans
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.