Conversation
Maps all FlowALPv0 entitlements to operations by resource, with plain-language descriptions. Intended for audit/security review. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Mark EPosition as protocol-internal only, not for end users - Add ownership-check warnings on all pool-level EPosition operations - Document the beta capability over-grant issue (EPosition -> EParticipant fix needed) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace resource-grouped columns with actor columns (User, User w/ EPosition, Rebalancer, Position Owner, Governance, Protocol Internal). The beta over-grant is now directly visible as a dedicated column showing what current beta users can do vs. what they should be able to do. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #177
Summary
Implements the full Actor Capability Matrix test suite for
FlowALPv0.Poolentitlements, as defined indocs/security-permission-matrix.mdDescription
cap_test.cdcThe previous file only validated pool creation. This PR replaces it with a structured security test suite covering every row in the permission matrix across all 6 entitlements — one test per matrix operation, organised in sections matching the matrix columns.
Negative test strategy
Cadence entitlements for Pool capabilities (EParticipant, EPosition, ERebalance, EGovernance, EImplementation) are enforced by the cadence type checker.
EPositionAdmin is the only entitlement in this file where negative (access-denied) tests are meaningful at runtime by borrowAuthorizedPosition, so testEPositionAdmin_BorrowUnauthorizedPosition_Fails exists.
Transaction reorganisation
Old
pool-management/andpool-governance/stubs removed. Replaced by entitlement-scoped folders matching the matrix columns:egovernance,eimplementation,eparticipant,eposition,epositionadmin,erebalance,setup(grant_e*_cap.cdc helpers),helpers(liquidation, insurance swapper, pool pause)docs/security-permission-matrix.mdEPosition | ERebalancefor rebalance ops;FungibleToken.Withdraw + EPositionAdminconjunction forborrowAuthorizedPosition).paid_auto_balance_test.cdc(rebalancer-local entitlements) andwithdraw_stability_funds_test.cdc(withdrawStabilityFund).Known issue documented (not fixed here)
publish_beta_cap.cdcgrantsEParticipant + EPositionto beta users.EPositionis not needed for normal user actions and allows any beta user to withdraw from or freeze any other user's position. The over-grant is explicitly tested in theeParticipantPositionUsersection. Fix: grantEParticipantonly — tracked separately.