Skip to content

fix: use deep comparison for launch params to prevent spurious warning #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
behnam-oneschema wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: use deep comparison for launch params to prevent spurious warning #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions packages/importer-react/src/OneSchemaImporter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,24 @@ export default function OneSchemaImporter({
}
}, [importer, style])

const prevParamsRef = useRef<string>()
useEffect(() => {
if (importer && importer._hasAttemptedLaunch && isOpen) {
const serializedParams = JSON.stringify(params)
const paramsChanged =
prevParamsRef.current !== undefined &&
prevParamsRef.current !== serializedParams
prevParamsRef.current = serializedParams

if (importer && importer._hasAttemptedLaunch && isOpen && paramsChanged) {
console.warn(
"The OneSchema importer has already launched. Updated launch params will not update the current import",
)
}
}, [params, importer, isOpen])
// NOTE: `params` is a new object reference on every render due to the
// `...rest` destructuring, so we track actual value changes via
// JSON.stringify instead of relying on referential equality.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [JSON.stringify(params), importer, isOpen])

useEffect(() => {
if (importer) {
Expand Down