Repository navigation
Conversation
olebedev
previously approved these changes
Oct 14, 2026
dualfroz
dismissed
olebedev’s stale review
October 14, 2026 07:46
The merge-base changed after approval.
olebedev
self-requested a review
October 14, 2026 07:47
olebedev
previously approved these changes
Oct 14, 2026
dualfroz
dismissed
olebedev’s stale review
October 14, 2026 07:54
The merge-base changed after approval.
olebedev
force-pushed
the
fix/21-deadline-without-prefix
branch
from
October 14, 2026 08:01
da5fa90 to
8381199
Compare
olebedev
approved these changes
Oct 14, 2026
Owner
|
Hi @dualfroz, there are merge conflicts in this branch, can you resolve them? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
went with what you described,
en.Deadline(rules.Override, en.DeadlineOptions{Aggressive: true})makes the prefix optional so2 hoursmatches too. default behaviour anden.Allstay the sameFixes #21