K8s scheduler - #271
Open
maccarth32 wants to merge 2 commits into
Open
Conversation
hagertnl
reviewed
Aug 3, 2026
| submit_args = | ||
|
|
||
| [SiteCustom] | ||
| kafka_uri = kafka.apps.gneiss.ccs.ornl.gov:30200 |
Contributor
There was a problem hiding this comment.
Can we scrub all these variables and move this file to configs/machine_examples? We shouldn't put these in the example ini files.
|
|
||
| from .base_scheduler import BaseScheduler | ||
|
|
||
| class K8S(BaseScheduler): |
Contributor
There was a problem hiding this comment.
We had initially discussed making an OpenShift-specific scheduler, then adding a generic kubectl/k8s scheduler later. If so, can we change this from "K8S" to "OpenShift"?
|
|
||
| def set_job_id_from_environ(self): | ||
| self.__logger.doInfoLogging("Setting job id from environment in k8s class") | ||
| jobvar = 'HOSTNAME' |
Contributor
There was a problem hiding this comment.
This kinda seems like there's not a job ID construct? Is that something we should try to remove from "requirements" for the scheduler implementation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@hagertnl could you kindly take a look and provide some feedback as I work on a direct
kubectlversion than this current Openshift version