Open
Conversation
akinomyoga
reviewed
Apr 19, 2025
Comment on lines
+61
to
+62
| if [[ -n "$VIRTUAL_ENV" ]]; then | ||
| val_venv=" ($(echo "$VIRTUAL_ENV" | awk -F/ '{print $(NF-1)"/"$NF}'))" |
Contributor
There was a problem hiding this comment.
I'm wondering what happens when VIRTUAL_ENV contains a newline in the path. The above would output multiple aaa/bbb pairs. Also, what happens when VIRTUAL_ENV doesn't contain any /? It would output / + $VIRTUAL_ENV, but I'm not sure if it's the intended behavior. I'd suggest simply doing
Suggested change
| if [[ -n "$VIRTUAL_ENV" ]]; then | |
| val_venv=" ($(echo "$VIRTUAL_ENV" | awk -F/ '{print $(NF-1)"/"$NF}'))" | |
| if [[ $VIRTUAL_ENV =~ [^/]+/[^/]+$ ]]; then | |
| val_venv=" ($BASH_REMATCH)" |
Contributor
There was a problem hiding this comment.
Also, what happens when
VIRTUAL_ENVdoesn't contain any/?
This hasn't been answered. Or is it ensured that it VIRTUAL_ENV contains /?
Co-authored-by: Koichi Murase <myoga.murase@gmail.com>
Contributor
Author
|
Thank you about your review @akinomyoga I just pushed these changes to my branch |
akinomyoga
reviewed
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a small update :)