Open
Conversation
chriptus13
force-pushed
the
add-gradle-plugin
branch
from
b430b69 to
263934e
Compare
akinomyoga
reviewed
Oct 6, 2024
| @@ -0,0 +1,25 @@ | |||
| # Gradle plugin | |||
|
|
|||
| This plugin adds completions and aliases for [Gradle](https://gradle.org/). | |||
Contributor
There was a problem hiding this comment.
This plugin doesn't seem to provide completions. Is there a plan to add them?
|
|
||
| function gradle-or-gradlew() { | ||
| # find project root | ||
| # taken from https://github.com/gradle/gradle-completion |
Contributor
There was a problem hiding this comment.
That code seems to be licensed under the MIT license, meaning that the original copyright notice should be retained. Please include it.
Contributor
I checked the upstream OMZ plugin and realized that this PR is actually not just similar but based on the OMZ plugin. In that case, could you also mention the upstream OMZ plugin in the code comment? Since the upstream is a moving target, it is better to keep the permalink that ours is based on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Gradle plugin similar to what we have in oh-my-zsh