feat(parser): adds IsEmpty() method for OptNil* generated wrappers#1667
Merged
Conversation
ernado
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When generating schemas with optional, nullable fields, it is often necessary to distinguish between a value being explicitly set to null versus being entirely omitted from the input (e.g., the "Zero" test case in the included examples).
ogen/internal/integration/json_test.go
Lines 84 to 104 in f48de28
To simplify this check, this PR introduces the
IsEmpty()method forOptNil***wrappers, providing a clean and efficient way to verify if a field was provided.Usage Example
Consider the following struct:
Before
Previously, checking for an omitted value required a more verbose approach:
After
With
IsEmpty(), the logic is much more concise: