Skip to content
This repository was archived by the owner on Apr 25, 2019. It is now read-only.

Mount fixes - #216

Open
kimocoder wants to merge 3 commits into
offensive-security:2019.2-devfrom
kimocoder:2019.2-dev
Open

kimocoder wants to merge 3 commits into
offensive-security:2019.2-devfrom
kimocoder:2019.2-dev

Conversation

@kimocoder

@kimocoder kimocoder commented Apr 23, 2019 •

Copy link
Copy Markdown
Contributor
  • bootkali slightly improved

  • killkali now works good, several mount issues suppressed.

  • Should had a check for external_sd in future
    when you not have it, something with mounts gets weird

*The same for /dev/shm, a check if it exists then unmount
If not, why then try at all

  • Added a "get-keychain" tool for pulling those apt-get issues, probably put a button in CustomCommads.

Forgot to add the get-keychain to the transfer/install script. will do.

* Now bootkali suppressed some issues
* killkali works perfect now
@kimocoder

Copy link
Copy Markdown
Contributor Author

Screenshot_20190423-072546

@Re4son

Re4son commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

Is there more coming to mount the external_sd?
Do we need the installation of the keyring? Wouldn't it be more likely that people with key issues download a new chroot rather than a new nethunter app?

@kimocoder

kimocoder commented Apr 23, 2019 •

Copy link
Copy Markdown
Contributor Author

It needs a check if external_sd actually exists instead of power run through
The same for /dev/shm partition, needs a check if supported/found.
My Nexus don't have it, OP6 got it again. Switches.

The get-keychain is more of an backup (used it alot past months again)

I'll get back to it soon. But as is, works good.

@Re4son

Re4son commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

So only works on phones without sd card, right?

@kimocoder

kimocoder commented Apr 23, 2019 •

Copy link
Copy Markdown
Contributor Author

The internal memory of Android is "sdcard", while "external_sd" is the physical card.
Phones who do not have external_sd (newer phones) will get mount issues, both on bootkali and killkali. But everyone has the /sdcard (internal memory) storage.

@kimocoder

Copy link
Copy Markdown
Contributor Author

And you have this /dev/shm and /dev partition available.

@Re4son

Re4son commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

Correct. What problems are we trying to solve? We seem to have had no issues with this commit:
e4d7b9c#diff-93d8f5c7f9f0edbf4090568456fea24b
And now we can't get the external sd card to mount. Why can't we roll back to the last known working commit? Is it Androind O or P related?

@Re4son

Re4son commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

By mount "issues", do you mean a warning that it cannot mount for any reason? That's not entirely undesirably because it tells us what's going on.

@kimocoder

kimocoder commented Apr 23, 2019 •

Copy link
Copy Markdown
Contributor Author

warnings is easy to go away, uncomment. no, but it try running those two last ones, so it's basicly just add check if exists, easy but I don't have more time atm

@Re4son

Re4son commented Apr 23, 2019

Copy link
Copy Markdown
Collaborator

No rush. I'll revert back to jcadduono's commit from 2017 and we'll leave that on the todo list for 2019.3, ok?

* Propably not the best solution, but should work
* Turned back "external_nd" mounts with check

Will have it tested/tweaked by tomorrow if it doesn't work out
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants