Conversation
|
Changed-file classification: backend/runtime. Author-reported runtime / visual state
Checkboxes are author attestations. GitHub Actions results remain the execution evidence for CI; this check does not prove that a local command ran. This comment updates automatically when the description or changed files change. |
RaresKeY
marked this pull request as ready for review
August 17, 2026 03:42
17 tasks
RaresKeY
force-pushed
the
fix/disable-agent-action-approval-gate
branch
from
August 17, 2026 16:30
c789a4c to
2a81fcb
Compare
This was referenced Aug 17, 2026
Open
RaresKeY
force-pushed
the
fix/disable-agent-action-approval-gate
branch
from
August 17, 2026 16:43
2a81fcb to
b135b62
Compare
RaresKeY
marked this pull request as draft
August 18, 2026 02:44
27 tasks
RaresKeY
force-pushed
the
fix/disable-agent-action-approval-gate
branch
from
August 19, 2026 10:40
b135b62 to
016d5e3
Compare
Member
Author
|
Important This should not merge atm |
RaresKeY
force-pushed
the
fix/disable-agent-action-approval-gate
branch
from
August 25, 2026 16:55
016d5e3 to
5636bed
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Important
This should not merge atm
Disables the temporary automatic agent-action approval gate so agent actions continue under the selected server-enforced sandbox boundary without per-action approval cards. The focused delta adds one explicit default-off switch, keeps the dormant behavior covered by opting it back in inside the legacy test module, and adds a regression for the production default. It does not weaken or bypass process sandboxing.
Stack
This PR is intentionally standalone and is based directly on current
dev; its unique delta is the focused gate change in commit016d5e330. It has no source dependency on the #5818 split or on the later authority/provenance slices. Runtime rollout can be coordinated after #6120 and #6121 land, while #6119 and #6118 remain transitive foundations of that runtime rather than direct dependencies.Target branch
dev, notmain. All PRs land indev;mainis curated by the maintainer at each release. If your PR is onmainby accident, click "Edit" on this PR and change the base.Linked Issue
Fixes #6083
Part of #5815
Related to PR #6120 and PR #6121 for runtime rollout ordering; this PR has no source dependency on either split substrate.
Type of Change
Checklist
devdocker compose uporuvicorn app:app) and verified the change works end-to-end. Type-checks and unit tests are not enough.How to Test
python -m pytest -q tests/test_agent_action_approval_gate_disabled.py tests/test_external_context_tool_gate.py tests/test_tool_approvals.py; the validated head reports 161 passing tests. The production-default regression allows sandboxed actions after external context, while the legacy suite explicitly re-enables and covers the dormant gate.python -m py_compile src/tool_capabilities.py tests/test_agent_action_approval_gate_disabled.py tests/test_external_context_tool_gate.py.git diff --check 87b93e657173d20e6b13079ee7063f9acc575edc...HEADand verifygit diff --stat 87b93e657173d20e6b13079ee7063f9acc575edc...HEADcontains onlysrc/tool_capabilities.pyplus the two focused test modules.Current focused validation on the exact public head reports 146 passed tests. Full-suite, live application, and runtime validation were not rerun as part of this restack.
Not run: live application flow, Docker/native runtime, or browser interaction.
Visual / UI changes — REQUIRED if you touched anything that renders
N/A — no rendered UI files are changed.
Screenshots / clips
N/A — no rendered UI files changed.