Skip to content

[FIX] topbar: fix readonly banner on mobile#7859

Closed
fw-bot wants to merge 1 commit intosaas-19.1from
saas-19.1-saas-18.4-fix-readonly-mobile-adrm-493367-fw
Closed

[FIX] topbar: fix readonly banner on mobile#7859
fw-bot wants to merge 1 commit intosaas-19.1from
saas-19.1-saas-18.4-fix-readonly-mobile-adrm-493367-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Collaborator

@fw-bot fw-bot commented Jan 23, 2026

Description

When the spreadsheet is in readonly mode, the readonly banner wasn't taking the full width of the topbar.

Task: 5342571

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #7723

@robodoo
Copy link
Copy Markdown
Collaborator

robodoo commented Jan 23, 2026

Pull request status dashboard

@fw-bot
Copy link
Copy Markdown
Collaborator Author

fw-bot commented Jan 23, 2026

@hokolomopo @pro-odoo cherrypicking of pull request #7723 failed.

stdout:

Auto-merging src/components/top_bar/top_bar.xml
Auto-merging tests/__snapshots__/top_bar_component.test.ts.snap
CONFLICT (content): Merge conflict in tests/__snapshots__/top_bar_component.test.ts.snap
Auto-merging tests/spreadsheet/__snapshots__/spreadsheet_component.test.ts.snap

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

When the spreadsheet is in readonly mode, the readonly banner wasn't
taking the full width of the topbar.

Task: 5342571
X-original-commit: 7596412
@hokolomopo hokolomopo force-pushed the saas-19.1-saas-18.4-fix-readonly-mobile-adrm-493367-fw branch from 73c648e to f750236 Compare January 27, 2026 12:42
@hokolomopo
Copy link
Copy Markdown
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Jan 27, 2026
When the spreadsheet is in readonly mode, the readonly banner wasn't
taking the full width of the topbar.

closes #7859

Task: 5342571
X-original-commit: 7596412
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
@robodoo robodoo closed this Jan 27, 2026
@fw-bot fw-bot deleted the saas-19.1-saas-18.4-fix-readonly-mobile-adrm-493367-fw branch February 3, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants