[FIX] menu: can open empty menu popover#7846
Closed
hokolomopo wants to merge 1 commit intosaas-18.4from
Closed
Conversation
Since the split of `Menu` and `MenuPopover`, we can open an empty menu, which is not desired. Two issues: - the `t-if` condition was plainly wrong, checking for the existence of the array rather than it's length. - the logic to know what menus are visible or not was in the `Menu` component, but is needed in the parent `MenuPopover` component to know if we should open the popover or not. Task: 5863077
Collaborator
|
|
robodoo
pushed a commit
that referenced
this pull request
Feb 2, 2026
Since the split of `Menu` and `MenuPopover`, we can open an empty menu, which is not desired. Two issues: - the `t-if` condition was plainly wrong, checking for the existence of the array rather than it's length. - the logic to know what menus are visible or not was in the `Menu` component, but is needed in the parent `MenuPopover` component to know if we should open the popover or not. closes #7846 Task: 5863077 Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since the split of
MenuandMenuPopover, we can open an empty menu, which is not desired.Two issues:
t-ifcondition was plainly wrong, checking for the existence of the array rather than it's length.Menucomponent, but is needed in the parentMenuPopovercomponent to know if we should open the popover or not.Task: 5863077
review checklist