[IMP] add keyboard navigation to menus#7780
Closed
hokolomopo wants to merge 1 commit intomasterfrom
Closed
Conversation
Collaborator
|
|
hokolomopo
force-pushed
the
master-menu-navigation-adrm
branch
5 times, most recently
from
c796ec1 to
09685e8
Compare
hokolomopo
force-pushed
the
master-menu-navigation-adrm
branch
from
09685e8 to
005ad7e
Compare
anhe-odoo
reviewed
Feb 17, 2026
|
|
||
| get popoverProps(): PopoverProps { | ||
| const isRoot = this.props.depth === 1; | ||
| const isRoot = this.props.depth === 0; |
Contributor
There was a problem hiding this comment.
Why did you change this number ?
Contributor
Author
There was a problem hiding this comment.
who the hell starts its indexes with 1 ???? (don't get me started about Matlab)
hokolomopo
force-pushed
the
master-menu-navigation-adrm
branch
from
005ad7e to
e199731
Compare
Collaborator
|
robodoo delegate+ |
hokolomopo
force-pushed
the
master-menu-navigation-adrm
branch
from
e199731 to
64c6342
Compare
Contributor
Author
|
@robodoo r+ |
Collaborator
|
@hokolomopo 'ci/runbot' failed on this reviewed PR. |
This commit adds the possibility to navigate with arrow keys/Enter/Escape in menus and topbar. It also simplifies the `Menu` component a bit by moving most of the logic in its parent component `MenuPopover`. Task: 5783408
hokolomopo
force-pushed
the
master-menu-navigation-adrm
branch
from
64c6342 to
ef13927
Compare
Contributor
Author
|
@robodoo r+ New ESLint rules 😔 |
robodoo
pushed a commit
that referenced
this pull request
Apr 15, 2026
This commit adds the possibility to navigate with arrow keys/Enter/Escape in menus and topbar. It also simplifies the `Menu` component a bit by moving most of the logic in its parent component `MenuPopover`. closes #7780 Task: 5783408 Signed-off-by: Adrien Minne (adrm) <adrm@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5783408
review checklist