Skip to content

Conversation

@Penwy
Copy link
Contributor

@Penwy Penwy commented Jul 17, 2025

Description

This simplifies the services recommended bitrate check, and allows it to function properly if there's more than one encoding session.
It also fixes the potential issue of the stream encoding session not having a bitrate, or not logging it as expected.

Motivation and Context

This was motivated by seeing the check fire from a recording session's bitrate instead of the stream's bitrate (log in question https://obsproject.com/logs/zGyyE5KFzk1b4KCT).

How Has This Been Tested?

Tested with manually created logs of every possible case I could think of.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@Penwy Penwy force-pushed the recommends-fix branch 3 times, most recently from b055b63 to 5285c34 Compare July 18, 2025 06:39
@RytoEX
Copy link
Member

RytoEX commented Jul 28, 2025

Per #185, log https://obsproject.com/logs/3zpBZBLcluZG6A3Q breaks with an error.

@Penwy Penwy force-pushed the recommends-fix branch 2 times, most recently from 543133c to 61dbaa8 Compare July 29, 2025 03:11
@Penwy
Copy link
Contributor Author

Penwy commented Jul 29, 2025

fixed, had forgotten the ignore message still shows up with TEB active.
Took the opportunity to fix a few other possible breakages, shorten the searches, and add a few comments on the bits in it that aren't too trivial on what they do.

Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix should be "network: ".

@RytoEX RytoEX changed the title checks: Improve service recommended bitrate check network: Improve service recommended bitrate check Sep 17, 2025
@RytoEX RytoEX merged commit e1512e5 into obsproject:master Sep 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants