network: Improve service recommended bitrate check #184
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the services recommended bitrate check, and allows it to function properly if there's more than one encoding session.
It also fixes the potential issue of the stream encoding session not having a bitrate, or not logging it as expected.
Motivation and Context
This was motivated by seeing the check fire from a recording session's bitrate instead of the stream's bitrate (log in question https://obsproject.com/logs/zGyyE5KFzk1b4KCT).
How Has This Been Tested?
Tested with manually created logs of every possible case I could think of.
Types of changes
Checklist: