[hpcman] iP - #623
Open
hpcman wants to merge 83 commits into
Open
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes
the shadowJar task to generate a second JAR file for which the
mainClass.set("seedu.duke.Duke") does not take effect.
Hence, this additional JAR file cannot be run.
For this product, there is no need to generate a second JAR file
to begin with.
Let's remove this dependency from the build.gradle to prevent the
shadowJar task from generating the extra JAR file.
WuJinhan1
reviewed
Sep 5, 2024
WuJinhan1
left a comment
WuJinhan1
left a comment
There was a problem hiding this comment.
Overall, LGTM! Just suggested that the files should be put inside a package.
| import java.util.ArrayList; | ||
| import java.util.Scanner; | ||
|
|
||
| public class PacMan { |
There was a problem hiding this comment.
I like how you named your chatbot PacMan! Putting a figure behind the chatbot gives it more character.
|
|
||
| Hello! I'm PacMan. How can I help you? | ||
| Got it. I've added this task: | ||
| [T][ ] CS2103T iP |
There was a problem hiding this comment.
I like how you made the tasks relevant to the class we are taking.
| @@ -0,0 +1,18 @@ | |||
| public class Task { | |||
| private final String taskName; | |||
| @@ -0,0 +1,10 @@ | |||
| public class Todo extends Task { | |||
| Todo(String task) { | |||
There was a problem hiding this comment.
I like how you split up each type of task into different files, making the code really clean!
| @@ -0,0 +1,13 @@ | |||
| public class Deadline extends Task { | |||
added 15 commits
September 6, 2024 13:13
This reverts commit 39d5276.
…iable name from to by in addDeadline method for readability
… TaskList.java, Todo.java, Ui.java to PacMan folder and bundle them to packages
The past GUI is bare bone and not visually appealing. The GUI needs to be better for visual appeal and easier to separate the command and response. Let's, * use CSS FXML to make the background and dialog box
Branch a code quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PacManPro
PacManPro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
mainmethod: