Skip to content

fix: Remember double page shift in auto pager mode - #668

Open
mar-krasnodebski wants to merge 1 commit into
null2264:masterfrom
mar-krasnodebski:fix/double-page-shift-rotation
Open

fix: Remember double page shift in auto pager mode#668
mar-krasnodebski wants to merge 1 commit into
null2264:masterfrom
mar-krasnodebski:fix/double-page-shift-rotation

Conversation

@mar-krasnodebski

Copy link
Copy Markdown

Summary

When using "Automatic" page layout, the "Shift Double Page" option doesn't persist across orientation changes. It means you cannot comfortably read in portrait mode and switch to landscape only for double page spreads, which is my main use case for the auto mode.

The same issue was reported and discarded in the upstream a long time ago: Jays2Kings/tachiyomiJ2K#1654

Steps to reproduce

  • Open file in portrait mode
  • Change orientation to landscape
  • Bring up the bottom menu bar
  • Click the Shift Double Page option
  • Pages are shifted properly
  • Change orientation to portrait
  • Change orientation to landscape
  • Pages are not shifted properly anymore

Extra info

  • Affected version: 1.9.7.5
  • Fix tested on: Onyx Boox NoteAir3C
  • The fix is very basic and doesn't survive reader exit, but it's a step in the right direction IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant